Repository navigation
design(dm-notifications-web): rev-1 — push and notification settings, DM inbox rows [squash] - #307
Merged
Merged
Conversation
added 2 commits
October 20, 2026 00:50
![congvc-bot[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft until the delta recheck passes, then ready for Cheese to merge. Design rev-1 for the web notification settings, DM inbox rows and banners, three directions. x99-codex-luna-2 scored rev-1 (UX scores in the design request thread). Cheese selected direction A. A selection is not an approval: Cheese approves by merging this PR. Merging admits no UI or service-worker implementation.
Conditions
packages/ui/styles/tokens.cssvalues. The app did not render it.NOT-CAPTURED: they need a signed-in session.visual diff: NOT-RUN.DESIGN.mdchanges in the selection commit only: the approved-revisions row for direction A, a pattern line and a sync withmain.rev-1/is unchanged since the scored revision0b7065192a3d456ef5bd06173aff361ae0924387.packages/views/issues/components/table-view.tsx:1868(missingresolveStatusLabeldependency) also appears onmain. This PR does not touch it.Change
Adds
design/dm-notifications-web/withREADME.mdandrev-1/:NOTES.mdlists six decisions for Cheese and the required states.Evidence
A|B|Cx1440|390) was captured on X99 with headless Chrome, full page, 128-colour palette, and checked for content.docs/designs/dm-search-notifications-push.md, section N4, and CHE-1848. Push payload fields come from the published N3 draft (PR feat(push): Web Push subscriptions, outbox and VAPID worker (CHE-1795) [squash] #304 head11cb9a671a0e580521a9c1701a9b0f4bcece346c): sender, label, count and URL, no message text and no DM title.Oversized image exemption: the six rev-1 PNGs (
A|B|Cx1440|390, 313 to 532 KB each) are full-page captures of long design boards, and they are the exact files a UX reviewer scores. A design revision is immutable, so smaller files would be a new revision. They are design-review evidence, not shipped product assets.Changelog: none
Part of CHE-1798