Issue #337: Replace three context strategy properties with a single contextStrategy property#421
Open
Brijeshthummar02 wants to merge 1 commit into
Open
Conversation
…a single contextStrategy property
63bbabf to
9d2eb5a
Compare
Contributor
Author
|
@romani need your feedback and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #337
Problem
SuppressionJavaPatchFilterhad three separate properties for controlling how the filter walks the AST when deciding whether to suppress a violation:supportContextStrategyChecks— used the check's own nodecheckNamesForContextStrategyByTokenOrParentSet— walked up to the parent nodecheckNamesForContextStrategyByTokenOrAncestorSet— walked up to a specific ancestor node typeDropping a check into the wrong property caused silent, incorrect suppression with zero indication anything went wrong. And the ancestor property had a hardcoded internal map that only covered a fixed set of built-in checks , custom checks were just left out with no workaround.
contextStrategyproperty:For more refer : #337 (comment)
The scope value accepts:
SELF/PARENT/ANCESTOR— direct replacements for the old three propertiesTokenTypesconstant (e.g.LITERAL_SWITCH,CLASS_DEF) — walks up to the first matching ancestor, which kills the need for the hardcoded map and finally makes ancestor-scope resolution available to custom checksThe old three properties are still around, marked
@Deprecated(since="10.x", forRemoval=true), and behave exactly as before they just log a warning pointing to the new syntax. Nothing in existing configs breaks.