Conversation
|
👍 IMHO, we should use a code sniffer to standardize source code. i.e. some files use |
|
I can quickly make the change. The classes I looked into were using Personally I would rather use [EDIT] |
|
Damn, my class is not standardized 😆 (BR Provider). Sorry! |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I find some differences here with my information from Wikipedia. Which source did you use?
| '03-19' => $this->createData('San José', array( | ||
| self::STATE_CM, | ||
| self::STATE_CV, | ||
| self::STATE_GA, | ||
| self::STATE_IB, | ||
| self::STATE_MA, | ||
| self::STATE_ME, | ||
| self::STATE_MU, | ||
| self::STATE_PA, | ||
| )), |
There was a problem hiding this comment.
Is that really right? See: https://en.wikipedia.org/wiki/Public_holidays_in_Spain
There was a problem hiding this comment.
Local/regional holidays change from one year to another. It seems impossible to integrate them automatically since they are decided arbitrarily
Public holidays celebrated in Spain include a mix of religious (Roman Catholic), national and regional observances. Each municipality is allowed to have a maximum of 14 public holidays per year; a maximum of nine of these are chosen by the national government and at least two are chosen locally.
If one of the "national holidays" happens to fall on a Sunday the regional governments — the autonomous communities of Spain — can choose an alternate holiday or they can allow local authorities to choose. In practice, except for holidays falling on a Sunday, the regional governments can choose up to three holidays per year; or they can choose fewer to allow for more options at the local level.
You can see it for instance at : https://www.calendarioslaborales.com/
| '03-19' => $this->createData('San José', array( | ||
| self::STATE_CM, | ||
| self::STATE_CV, | ||
| self::STATE_GA, | ||
| self::STATE_IB, | ||
| self::STATE_MA, | ||
| self::STATE_ME, | ||
| self::STATE_MU, | ||
| self::STATE_PA, | ||
| )), | ||
| '04-23' => $this->createData('Día de la comunidad', array( | ||
| self::STATE_AR, | ||
| self::STATE_CA, | ||
| self::STATE_CL, | ||
| )), |
| const STATE_AN = 'Andalucía'; | ||
| const STATE_AR = 'Aragón'; | ||
| const STATE_CA = 'Cataluña'; | ||
| const STATE_CE = 'Ceuta'; | ||
| const STATE_CL = 'Castilla y León'; | ||
| const STATE_CM = 'Castilla La Mancha'; | ||
| const STATE_CN = 'Cantabria'; | ||
| const STATE_CV = 'Comunidad Valenciana'; | ||
| const STATE_EX = 'Extremadura'; | ||
| const STATE_GA = 'Galicia'; | ||
| const STATE_IB = 'Islas Baleares'; | ||
| const STATE_IC = 'Islas Canarias'; | ||
| const STATE_LR = 'La Rioja'; | ||
| const STATE_MA = 'Madrid'; | ||
| const STATE_ME = 'Melilla'; | ||
| const STATE_MU = 'Murcia'; | ||
| const STATE_PA = 'Principado de Asturias'; | ||
| const STATE_PV = 'País Vasco'; |
There was a problem hiding this comment.
Looks like NC is missing?
https://en.wikipedia.org/wiki/Navarre
2 participants
No description provided.