Conversation
noyobo
force-pushed
the
fix-34-push-with-tags
branch
from
September 20, 2026 14:13
4844421 to
f13bb7d
Compare
libgit2 Remote::push looks up the glob as a literal ref. Enumerate local tags
and push refs/tags/{name}:refs/tags/{name} so Push with tags works.
noyobo
force-pushed
the
fix-34-push-with-tags
branch
from
September 20, 2026 14:20
f13bb7d to
b36deb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #34.
Push with tags sends
refs/tags/*:refs/tags/*. libgit2Remote::pushdoes not expand that glob — it looks up a literal ref namedrefs/tags/*and fails withclass=Invalid (3).git push --tagsexpands the glob locally first. Single-tagpush_tagalready uses a named spec and works.The engine now lists local tags and pushes
refs/tags/{name}:refs/tags/{name}next to the branch spec. Force still prefixes only the branch. Regression:push_with_tags_sends_named_tag_refsagainst a local bare remote.Screenshots
N/A — engine behavior only.
Checklist
tests/git_engine.rspush_refspecsunit tests name tags instead of the globcargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test(Rust CI)Made with Cursor