Repository navigation
Move the engine pin to v26.9.0 - #60
Open
github-actions[bot] wants to merge 3 commits into
Open
github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release check built and ran the tests against
v26.9.0andthey passed, so the engine can be adopted. This moves the pin
v26.7.3 →
v26.9.0in all three places that carry it:update_libchdb.sh,build.rs, andengineunder[package.metadata.chdb]inCargo.toml, which is what tells a userof the published crate which engine is inside it.
https://github.com/chdb-io/chdb-rust/actions/runs/36533219125
Based on 20c25fa, the commit that run tested.
No checks will appear here. GitHub does not start workflow runs for
commits a workflow pushed with
GITHUB_TOKEN, and running CI on thisbranch would exercise the same tests against the same engine the check
just used.
Note
Move engine pin to v26.9.0
CHDB_ENGINE_PINfrom v26.7.3 to v26.9.0 in Cargo.toml, build.rs, and update_libchdb.shinsert_record_batch_directandinsert_record_batch_readerin arrow_insert.rs to yield the connection call as the block result; fallback SQL paths remain conditionally compiledCHDB_ENGINE_PINconsumers in build.rsMacroscope summarized 7d9f5dd.