feat(dex): add search, sorting, and filters to Pokédex and Catch Log - #329
Open
KillianHzr wants to merge 2 commits into
Open
KillianHzr wants to merge 2 commits into
KillianHzr wants to merge 2 commits into
Conversation
- Add search bar matching by species name, # ID, and multilingual names - Add sorting options: Pokédex number asc/desc, name A-Z / Z-A, and rarity descending - Add Catch Log sorting options: most recent / oldest first, number asc/desc, name, and rarity - Add shiny-only filter toggle with visual indicator - Add empty search results state with reset filters button - Support all 7 application languages - Add comprehensive unit test suite in DexSearchAndFilterTests
…n DexSearchAndFilterTests - Initialize CompanionStore via encoded file to avoid private state setter access - Use boolean comparison checks for ComparisonResult ordering - Remove unused store instance in localization test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive search, sorting, and filtering capabilities to both the Pokédex grid and the Catch Log (Journal de captures) in the Collection tab:
25or#25), and multilingual translations stored in saves. Includes a clear button (xmark.circle.fill).ko,en,ja,es,fr,pt,de).DexSearchAndFilterTests.swift.Type of change
UI changes
Checklist
swift buildandswift testpass locally