Merged
Conversation
nicodh
force-pushed
the
add-create-qr-svg-to-jsonrpc
branch
from
a7d7007 to
1183e80
Compare
link2xt
approved these changes
Mar 4, 2026
| /// if `checkQr()` returns `askVerifyContact` or `askVerifyGroup` | ||
| /// an out-of-band-verification can be joined using `secure_join()` | ||
| /// | ||
| /// @deprecated as of 2026-03; use create_qr_svg(get_chat_securejoin_qr_code()) instead. |
Collaborator
There was a problem hiding this comment.
rustdoc does not care about doxygen commands
Contributor
Author
There was a problem hiding this comment.
The idea is that since these will be moved to the typescript comments there they will be recognized by IDEs & editors in clients.
/**
* @deprecated as of 2026-03; use create_qr_svg(get_chat_securejoin_qr_code()) instead.
* return format: `[code, svg]`
*
*/
getChatSecurejoinQrCodeSvg(accountId: T.U32, chatId: (T.U32 | null)): Promise<[string, string]>;
Contributor
Author
There was a problem hiding this comment.
In the jsonrpc module that would make sense imo. Maybe even rewrite the existing deprecated comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for deltachat/deltachat-desktop#5969 and followup to #6090
Tested with desktop