Fix static analysis violations with cursor pagination

[tolry]

When using cursor pagination, access to has_more and cursor are labelled as violations by phpstan or psalm, since those properties are protected on AbstractModel although they are readable publicly via __get()

sample code

$cursor = null;
do {
    $filter = ["customer_uuid" => $uuid];
    if ($cursor) {
        $filter["cursor"] = $cursor;
    }

    $collection = \ChartMogul\CustomerInvoices::all($filter);

    foreach ($collection->invoices as $invoice) {
        // do something
    }

    $cursor = $collection->cursor;
} while ($collection->has_more);

[swember]

Hello @tolry, thanks a lot for the contribution. Could you please provide which settings for phpstan you use. I tried to create a new project and use your code in it and I haven't got any complaints from phpstan.

[tolry]

Hi @swember, thanks for being patient. We baselined these issue and haven't thought about them for a while. I double-checked right now, and we still need to put it into our baseline.

The issue does occur for us running PHPStan at level 8. So everything from level 8 or higher should trigger the issue.

If I remove this from the baseline file, the following violation is printed:

$ vendor/bin/phpstan

Note: Using configuration file [...]/phpstan.neon.

 ------ ----------------------------------------------------------------------------------------
  Line   [...]/Command/SynchronizeChartMogulCommand.php
 ------ ----------------------------------------------------------------------------------------
  251    Access to protected property ChartMogul\CustomerInvoices::$has_more.
         🪪  property.protected
 ------ ----------------------------------------------------------------------------------------