Skip to content

fix(types): add [number, number] tuple support for line and scatter chart defaultDataPoint #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subodhbhyri wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −2
Open

fix(types): add [number, number] tuple support for line and scatter chart defaultDataPoint #12250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3764,15 +3764,15 @@ export interface ChartTypeRegistry {
line: {
chartOptions: LineControllerChartOptions;
datasetOptions: LineControllerDatasetOptions & FillerControllerDatasetOptions;
defaultDataPoint: ScatterDataPoint | number | null;
defaultDataPoint: ScatterDataPoint | number | [number, number] | null;
metaExtensions: {};
parsedDataType: CartesianParsedData;
scales: keyof CartesianScaleTypeRegistry;
};
scatter: {
chartOptions: ScatterControllerChartOptions;
datasetOptions: ScatterControllerDatasetOptions;
defaultDataPoint: ScatterDataPoint | number | null;
defaultDataPoint: ScatterDataPoint | number | [number, number] | null;
metaExtensions: {};
parsedDataType: CartesianParsedData;
scales: keyof CartesianScaleTypeRegistry;
Expand Down
8 changes: 8 additions & 0 deletions test/types/data_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ const chart = new Chart('chart', {
}
});

const lineTupleChart = new Chart('lineTupleChart', {
type: 'line',
data: {
labels: ['1', '2', '3'],
datasets: [{ data: [[1, 2], [3, 4], [5, 6]] }],
}
});

const chart2 = new Chart('chart2', {
type: 'bar',
data: {
Expand Down
8 changes: 8 additions & 0 deletions test/types/dataset_null_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,11 @@ const radarDataset: ChartDataset<'radar'> = {
data: [10, null, 20],
};

// [number, number] tuple data must be accepted for line and scatter, matching bar's floating-range behaviour
const lineTupleDataset: ChartDataset<'line'> = {
data: [[1, 2], [3, 4], [5, 6]],
};
const scatterTupleDataset: ChartDataset<'scatter'> = {
data: [[1, 2], [3, 4], [5, 6]],
};