Mounted Assets & Links

[markvanlan]

Based on @piasekhgw's fork, this branch uses Sprockets instead of sinatra/assetpack (which is no longer maintained), and appends the app_prefix to asset paths and links so they work when mounted in a Rails application.

I did not touch the websocket routes (which probably need @appPrefix prepended to them), but would love for someone to continue on this path so gush-control works well mounted.

[pokonski]

Very nice! It's been a while since I actually used gush control personally so will need a bit to set up a project to review this :)

[nathancolgate]

Hi, @pokonski ! I work with @markvanlan and we are using gush in a new client project.

First: thanks so much for the gem. We all agree it is the perfect solution to the problem we are trying to solve.

Second: The project is big enough that we should have the opportunity to invest back into gush-control (and possibly even gush, after looking at some of the changes @piasekhgw did).

We'd love to know what you think the direction of gush-control is.

For instance: now that gush uses ActiveJob, is it leaning towards being Rails-based? If so: we could help make gush-control a better Rails-specific mounted engine (using ActionCable instead of WebSockets). If not: we could help make it a better stand alone tool that runs well inside a docker container. Or whatever you think is a good direction.

Please don't hesitate to get in touch!

[pokonski]

Hey @nathancolgate gush can still be used without Rails, but ActiveJob helped reach the goal of being "sidekiq indepedent" without me reinventing the wheel :)

But I agree that (based on a hunch!) most consumers of gush are Rails apps, so going in that direction seems very reasonable.

Having a Docker image would also be great! So I'll definitely could use the help modernizing it, especially from people who actively use it 👍

[nathancolgate]

Hey @pokonski ! It's been a couple years. The project we used this on is up and running just fine without this. How would you feel about closing this PR?