[Grenoble] Améliorer le lien de création de groupe à partir d'une classe, refs #5774 #1709 #1710s#7511
Closed
chamilo-uga wants to merge 3 commits intochamilo:masterfrom
Closed
Conversation
Member
|
Ça m'a l'air beaucoup mieux. Je vois avec Angel pour valider ceci rapidement, mais ça ne fera pas encore partie de la RC2. |
AngelFQC
requested changes
Mar 17, 2026
public/main/group/group.php
Outdated
Comment on lines
+247
to
+258
| 0, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| 0, | ||
| 1, | ||
| 0, | ||
| 0 |
Member
There was a problem hiding this comment.
You might want to use the predefined constants GroupManager::TOOL_NOT_AVAILABLE, GroupManager::TOOL_PUBLIC or GroupManager::TOOL_PRIVATE for better readability
Comment on lines
+464
to
+469
| 1, | ||
| 1, | ||
| 1, | ||
| 1, | ||
| 1, | ||
| 1 |
Member
|
Fixed and re-submitted through #8091 |
Member
|
The fix includes CSRF and SQL injection fixes! 👀 |
Member
|
@chamilo-uga when submitting new language terms, please make sure msgid an msgstr are identical in messages.en_US.po (they were not in the last string) and that you also submit the same strings (without the msgstr) to messages.pot (which is the "index"). |
ywarnier
added a commit
to ywarnier/chamilo-lms
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to
Replace closed PR6295
Ce PR prend en compte les corrections demandées.
J'ai clos l'ancien PR qui provenait d'un autre compte Github [eristich], et je n'ai pas réussi à pusher sur le même PR de ce compte.