Fix: preserve newlines for folded style (>) YAML blocks#114
Open
aryasoni98 wants to merge 1 commit intochainguard-dev:mainfrom
Open
Fix: preserve newlines for folded style (>) YAML blocks#114aryasoni98 wants to merge 1 commit intochainguard-dev:mainfrom
aryasoni98 wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
luhring
suggested changes
Aug 22, 2025
Contributor
luhring
left a comment
There was a problem hiding this comment.
Thank you for looking at this! Looks like a nice start.
Can you add some test cases to express the correct behavior we're expecting here, and to ensure that this change is fixing the bug? Check out https://github.com/chainguard-dev/yam/blob/main/pkg/yam/formatted/encoder_test.go to see how we're handling testing for other parts of this file. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that yam preserves newlines for folded style (>) YAML blocks, rather than joining lines into a single line. This resolves issue #112 and brings yam’s output in line with YAML spec and user expectations.