Repository navigation
build(deps): bump the gomod group across 1 directory with 12 updates - #2753
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the gomod group with 12 updates in the / directory: | Package | From | To | | --- | --- | --- | | chainguard.dev/apko | `1.4.15` | `1.5.1` | | chainguard.dev/license | `0.1.2` | `0.1.5` | | [github.com/chainguard-dev/yam](https://github.com/chainguard-dev/yam) | `0.2.69` | `0.2.71` | | [github.com/docker/cli](https://github.com/docker/cli) | `29.9.2+incompatible` | `29.10.0+incompatible` | | [github.com/klauspost/compress](https://github.com/klauspost/compress) | `1.20.3` | `1.20.4` | | [github.com/spf13/pflag](https://github.com/spf13/pflag) | `1.0.10` | `1.1.0` | | [golang.org/x/crypto](https://github.com/golang/crypto) | `0.58.0` | `0.59.0` | | [golang.org/x/sync](https://github.com/golang/sync) | `0.24.0` | `0.25.0` | | [golang.org/x/sys](https://github.com/golang/sys) | `0.49.0` | `0.50.0` | | [golang.org/x/term](https://github.com/golang/term) | `0.47.0` | `0.48.0` | | [golang.org/x/text](https://github.com/golang/text) | `0.43.0` | `0.44.0` | | gopkg.in/ini.v1 | `1.67.3` | `1.68.0` | Updates `chainguard.dev/apko` from 1.4.15 to 1.5.1 Updates `chainguard.dev/license` from 0.1.2 to 0.1.5 Updates `github.com/chainguard-dev/yam` from 0.2.69 to 0.2.71 - [Commits](chainguard-dev/yam@v0.2.69...v0.2.71) Updates `github.com/docker/cli` from 29.9.2+incompatible to 29.10.0+incompatible - [Commits](docker/cli@v29.9.2...v29.10.0) Updates `github.com/klauspost/compress` from 1.20.3 to 1.20.4 - [Release notes](https://github.com/klauspost/compress/releases) - [Commits](klauspost/compress@v1.20.3...v1.20.4) Updates `github.com/spf13/pflag` from 1.0.10 to 1.1.0 - [Release notes](https://github.com/spf13/pflag/releases) - [Commits](spf13/pflag@v1.0.10...v1.1.0) Updates `golang.org/x/crypto` from 0.58.0 to 0.59.0 - [Commits](golang/crypto@v0.58.0...v0.59.0) Updates `golang.org/x/sync` from 0.24.0 to 0.25.0 - [Commits](golang/sync@v0.24.0...v0.25.0) Updates `golang.org/x/sys` from 0.49.0 to 0.50.0 - [Commits](golang/sys@v0.49.0...v0.50.0) Updates `golang.org/x/term` from 0.47.0 to 0.48.0 - [Commits](golang/term@v0.47.0...v0.48.0) Updates `golang.org/x/text` from 0.43.0 to 0.44.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.43.0...v0.44.0) Updates `gopkg.in/ini.v1` from 1.67.3 to 1.68.0 --- updated-dependencies: - dependency-name: chainguard.dev/apko dependency-version: 1.5.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: chainguard.dev/license dependency-version: 0.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/chainguard-dev/yam dependency-version: 0.2.71 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/docker/cli dependency-version: 29.10.0+incompatible dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/klauspost/compress dependency-version: 1.20.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/spf13/pflag dependency-version: 1.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: golang.org/x/crypto dependency-version: 0.59.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: golang.org/x/sync dependency-version: 0.25.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: golang.org/x/sys dependency-version: 0.50.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: golang.org/x/term dependency-version: 0.48.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: golang.org/x/text dependency-version: 0.44.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: gopkg.in/ini.v1 dependency-version: 1.68.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod ... Signed-off-by: dependabot[bot] <support@github.com>
Code reviewers3 findings (3 low) · reviewed 09cfda1
Standards: 1 read, 0 left out
Reviewers are configured in |
There was a problem hiding this comment.
reviewer/melange · Commented
Verdict: comment. 0 Blocking, 3 Questions, 0 Pre-existing. I reviewed the go.mod and go.sum bump against the code paths that use these modules. The sandbox has no Go toolchain and no module cache, so I could not confirm that the APK bytes, the build guest and the build-time license check stay the same. Each of those is asked as a question inline.
| github.com/joho/godotenv v1.5.1 | ||
| github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 | ||
| github.com/klauspost/compress v1.20.3 | ||
| github.com/klauspost/compress v1.20.4 |
There was a problem hiding this comment.
reviewer/melange · low
Question: Does klauspost/compress v1.20.4 produce different gzip bytes for the same input? Its release notes list flate: build unrestricted Huffman trees before limiting lengths (#1219) and flate: keep match history across small flushes (#1282). Both change how flate encodes. melange writes every APK section with this library: the control and provenance sections use gzip.NewWriter at pkg/build/package.go:314 and :516, and the data section uses pgzip.NewWriter at :468, which is built on klauspost flate. The data hash goes into .PKGINFO. If the output changes, melange rebuild with this melange on an APK that an earlier melange built will fail. diffAPKs in pkg/cli/rebuild.go:391-393 reports APK digest diff, and .PKGINFO differs as well. AGENTS.md (Sources and provenance) asks that melange rebuild keep producing the same bytes. The e2e rebuild job in .chainguard/ci/e2e.yaml:130-133 builds and rebuilds with the same binary, so it would not catch this. Please confirm the output is byte-identical, for example by compressing a fixed tarball with v1.20.3 and v1.20.4 and comparing. If it is not, say so in the pull request so rebuild drift for existing Wolfi APKs is expected.
| require ( | ||
| chainguard.dev/apko v1.4.15 | ||
| chainguard.dev/license v0.1.2 | ||
| chainguard.dev/apko v1.5.1 |
There was a problem hiding this comment.
reviewer/melange · low
Question: apko moves from 1.4.15 to 1.5.1, a minor release. The pull request body has no changelog for it. melange uses apko to build the build guest (chainguard.dev/apko/pkg/build, pkg/build/types, pkg/options) and to resolve and install packages (pkg/apk/apk, pkg/apk/fs). Did 1.5.x change any default that reaches the guest, such as the user, the environment, certificates, the accounts it writes or package resolution? Did it change the signature of any exported identifier melange calls? A change in what the build guest sees would change Wolfi builds on all three runners, and AGENTS.md (Compatibility) requires that an existing melange file build the same package.
| chainguard.dev/apko v1.4.15 | ||
| chainguard.dev/license v0.1.2 | ||
| chainguard.dev/apko v1.5.1 | ||
| chainguard.dev/license v0.1.5 |
There was a problem hiding this comment.
reviewer/melange · low
Question: chainguard.dev/license moves from 0.1.2 to 0.1.5. Every build runs license.LicenseCheck at pkg/build/build.go:878, and an error there fails the build. That check fails a build when detect reports unreadable paths or a per-file Err (pkg/license/license.go:213-234). It also decides which licenses are detected. Did 0.1.3 to 0.1.5 change what detect.Detect treats as unreadable or as an error, or change its scope, ConfidenceThreshold or MaxTextBytes? A stricter result there would turn a passing Wolfi build into a failing one.
Bumps the gomod group with 12 updates in the / directory:
1.4.151.5.10.1.20.1.50.2.690.2.7129.9.2+incompatible29.10.0+incompatible1.20.31.20.41.0.101.1.00.58.00.59.00.24.00.25.00.49.00.50.00.47.00.48.00.43.00.44.01.67.31.68.0Updates
chainguard.dev/apkofrom 1.4.15 to 1.5.1Updates
chainguard.dev/licensefrom 0.1.2 to 0.1.5Updates
github.com/chainguard-dev/yamfrom 0.2.69 to 0.2.71Commits
b9edb1abuild(deps): bump chainguard-actions/reviewdog-action-actionlint from 1.81.2 ...12163d4build(deps): bump chainguard-dev/actions/git-tag from 1.8.0 to 1.8.1 (#293)a527a27build(deps): bump step-security/harden-runner from 2.22.3 to 2.22.4 (#290)5d3b5a9build(deps): bump chainguard-actions/reviewdog-action-actionlint from 1.79.1 ...09ce035build(deps): bump chainguard-dev/actions/git-tag from 1.7.2 to 1.8.0 (#287)3beae0abuild(deps): bump zizmorcore/zizmor-action from 0.8.0 to 0.8.1 (#286)b1a8655fix(ci): swap step-security actions to chainguard-actions mirrors (#288)c162387build(deps): bump chainguard-dev/actions/git-tag from 1.6.40 to 1.7.2 (#283)fcb020dbuild(deps): bump step-security/harden-runner from 2.21.1 to 2.22.3 (#284)b2e6a7eci(zizmor): bump zizmor-action to v0.8.0 and allow PyPI egress (#285)Updates
github.com/docker/clifrom 29.9.2+incompatible to 29.10.0+incompatibleCommits
fdd4b8eMerge pull request #7519 from thaJeztah/bump_api_clientcdb042dvendor: github.com/moby/moby/client v0.6.3bbbf466vendor: github.com/moby/moby/api v1.57.0eaae503Merge pull request #7515 from xh123637/fix/7514-no-success-on-copy-failure25552bacontainer/cp: don't print success message when copy fails6eb5fafMerge pull request #7517 from thaJeztah/rm_docse439fbeMerge pull request #7509 from thaJeztah/bump_creds_helpers17b57bbMerge pull request #7312 from a3ylf/fix/gpu-duplicate-count71758c7Merge pull request #7516 from docker/dependabot/github_actions/docker-actions...d4906a8remove daemon-related documentation that moved to the moby repositoryUpdates
github.com/klauspost/compressfrom 1.20.3 to 1.20.4Release notes
Sourced from github.com/klauspost/compress's releases.
Commits
361b808s2: keep ErrCorrupt when Skip rejects an oversized chunk (#1303)7556d8as2: return ErrDstTooSmall for an LZ4 conversion into a nil dst (#1307)5763a8dgzhttp: clear Content-Length when decoding a compressed request (#1301)d8a2412zstd: don't reuse a literal table that was not written (#1299)a4c846bs2: fix LZ4 converter length overflow (32-bit only) (#1300)de5f3e2zstd: cap DecodeAll preallocation to what the input can decode to (#1291)1e5ae79zip: backport the standard library's writer-side Zip64 fixes (#1287)b143364s2: don't read past src when converting LZ4 blocks (#1294)b660d6dzstd: copy non-overlapping matches in 32-byte blocks (#1295)f2783fbzstd: inline the best encoder's reject path; cap concurrent-blocks job size (...Updates
github.com/spf13/pflagfrom 1.0.10 to 1.1.0Release notes
Sourced from github.com/spf13/pflag's releases.
... (truncated)
Commits
f8a9906Merge pull request #533 from gdpu11/fix/count-preserve-value-on-errorf3a68a1Merge pull request #534 from gdpu11/fix/native-integer-ranges70f7745fix: reject native integer flag overflow on 32-bit systems2084408test: cover native integer flag bounds on 32-bit systems7d0f377fix: preserve count flag values when parsing failsd26a4dcMerge pull request #526 from dewanshshekhar/fix/text-flag-type-check2d401c7Fix type identification for text flagsfa584baMerge pull request #520 from adenzhou1350/codex/fix-copy-go-string-valuecc9e689Merge upstream master and retain its linter version70f284bMerge pull request #521 from Harshil-1603/fix/string-map-recordsUpdates
golang.org/x/cryptofrom 0.58.0 to 0.59.0Commits
6c966a7ssh: quote remaining peer-controlled strings in error messagesbc46121ssh: fail OpenChannel when the connection is lost7e0915cssh/test: connect to sshd over a loopback TCP connectionbfa619essh/agent: use a short socket path for ssh-agent in tests4e10f38go.mod: update golang.org/x dependenciesa1058ebssh: remove DSA supportd580ab7ssh: report algorithms of the last completed key exchanged1f31f6ssh/knownhosts: skip lines that cannot be parsed04c6b4fssh: return rest from ParseKnownHosts on parse errors3d426adssh: separately count rejected public key queries towards MaxAuthTriesUpdates
golang.org/x/syncfrom 0.24.0 to 0.25.0Commits
1f920dfsyncmap: rename DeepCopyMap to CopyMapUpdates
golang.org/x/sysfrom 0.49.0 to 0.50.0Commits
00227f1unix: avoid using stale written count from sendfile on freebsd/386 after EINVALaa1b965unix: don't skip directory entries with zero inodes on Linux37845fbunix: reject a short SCM_CREDENTIALS payload in ParseUnixCredentials313c631unix: add IoctlGetUint644a36a34cpu: add wasm32 "architecture"908ab59windows: use SyscallN consistently for Windows system callsf5cb030unix: set R12 before the ppc64x syscall branch0e9e10fwindows: remove MemoryBasicInformation.PartitionId field on windows/3869b24ac0windows: fix PSAPI_WORKING_SET_EX_BLOCK bit accessors69a6691windows/mkwinsyscall: read 32-bit results from the low half of the return reg...Updates
golang.org/x/termfrom 0.47.0 to 0.48.0Commits
91b1235go.mod: update golang.org/x dependenciesUpdates
golang.org/x/textfrom 0.43.0 to 0.44.0Commits
6070ac3go.mod: update golang.org/x dependencies972f268language: count '_' alongside '-' in ParseAcceptLanguage guard367ce9einternal/export/idna: avoid excessive work in Punycode encodingUpdates
gopkg.in/ini.v1from 1.67.3 to 1.68.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions