Fix inconsistent staging URL logic in SimpleChart - #9015
Open
chosak wants to merge 1 commit into
Open
Conversation
SimpleChart has some logic that leverages wagtail-sharing [0] logic to dynamically alter chart source data when unpublished drafts are being previewed. If a page is being served by w-s, chart data source URLs that contain "production" get altered to instead pull from "staging". An example page where this behavior can be observed is https://www.consumerfinance.gov/enforcement/payments-harmed-consumers/civil-penalty-fund/. If one views this page on our w-s domain, one observes that the download link under the chart points to "production". Looking in the browser console, however, shows that the data gets pulled from "staging". Hackiness of this approach aside, one might wonder why the data source is altered, but the download link is not. If the idea is to use this w-s logic to allow for preview of staged data, perhaps the download link should be updated along with the data source. [0] https://github.com/cfpb/wagtail-sharing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleChart has some logic that leverages wagtail-sharing logic to dynamically alter chart source data when unpublished drafts are being previewed.
If a page is being served by w-s, chart data source URLs that contain "production" get altered to instead pull from "staging".
An example page where this behavior can be observed is https://www.consumerfinance.gov/enforcement/payments-harmed-consumers/civil-penalty-fund/. If one views this page on our w-s domain, one observes that the download link under the chart points to "production". Looking in the browser console, however, shows that the data gets pulled from "staging".
Hackiness of this approach aside, one might wonder why the data source is altered, but the download link is not. If the idea is to use this w-s logic to allow for preview of staged data, perhaps the download link should be updated along with the data source.
Ping @wpears who last updated this code in #7115.