Adding byline support to text introductions - #7348
Closed
csebianlander wants to merge 3 commits into
Closed
Conversation
Member
|
@csebianlander I rebased and expanded this in #7367 to avoid the duplication of byline code; would you mind giving that a look? |
Contributor
Author
|
No longer applicable and/or would probably need to be fully rethought for integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blog posts currently support the generation of bylines using the
item-introductionblock. We have a need for other page types to use a byline. This PR modifies thetext-introductiontemplate and corresponding molecule block to create the same byline in the same manner.Additions
text-introduction.htmltemplateHow to test this PR
Screenshots
Back-end:

Front-end:

Notes and todos
Checklist
/docsfolder) – for basic, close-to-the-code docs on working with this repo