JSON cleanup, list view clean up - #626
Open
flacoman91 wants to merge 45 commits into
Open
Conversation
Keep JSON available for full-dataset downloads from files.consumerfinance.gov, and update tour copy and tests to match.
Filtered downloads are always CSV, so only show format radios for the full dataset and drop the redundant format from filtered export analytics.
…anup Bring in CSV-only filtered export URL building and related tour copy.
|
flacoman91
force-pushed
the
rad-list-view-cleanup
branch
from
July 30, 2026 23:04
4fd72b1 to
37561df
Compare
|
Coverage is 87.927% — rad-list-view-cleanup into main. No base build found for |
action bar cleanup more cleanup to match mock remove spyglass icons from search button clean up styling eslint nag clean up resp lint fixes fix update things clean up cleanup more more cleanup update pills save work clean pill alignment
flacoman91
force-pushed
the
rad-list-view-cleanup
branch
from
July 31, 2026 04:31
4fcb55a to
a62cbf3
Compare
Removed dead h4.content-header from hero Retargeted expandable max-width to .o-expandable__label Removed dead date-filter h4 margin rule Updated print selectors from .search-panel h2 → h3
flacoman91
force-pushed
the
rad-list-view-cleanup
branch
from
August 1, 2026 08:05
5e69596 to
c2a3aab
Compare
Avoid updating refs during render and use bare setTimeout/clearTimeout for CI eslint.
Bring in Cypress testing-library selector updates from main, keep this branch's download/list UI, and point DSR at the latest rad-tabs-inverted commit.
fix merge fix tests after merge Simplify RootModal to a boolean More About dialog state. Remove the unused export confirmation modal and typed modal map now that downloads live on the list view. Move RootModal locals after the early return. Satisfies unicorn/no-declarations-before-early-exit while keeping hooks above the exit. update dist align carets fix cypress Align Cypress filter toggle names with list-view titles. Fix Cypress filter selectors for pill panel and branch toggles. Match current copy and give aggregation expand buttons a stable aria-label so tests can find Mortgage without relying on count text.
flacoman91
force-pushed
the
rad-list-view-cleanup
branch
from
August 3, 2026 05:59
06567e8 to
e842c6b
Compare
Give users field-level feedback that the file is downloading, while keeping the existing error alerts for empty and over-limit filtered exports.
Add Babel TS support and a typecheck script, convert a few pure utils/constants plus refine-bar Select, and tighten search tips spacing.
remove custom icons in favor of text mobile fixes, fix widths < 800 stack narratives
Give expandable content and Has Narrative a consistent 30px bottom gap before HRs so Show more and the narratives checkbox align.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To verify, validate against figma mockups: