Skip to content

DATAP-2042 - Remove JSON format - #619

Open
flacoman91 wants to merge 24 commits into
mainfrom
rad-remove-filtered-json-export
Open

DATAP-2042 - Remove JSON format#619
flacoman91 wants to merge 24 commits into
mainfrom
rad-remove-filtered-json-export

Conversation

@flacoman91

@flacoman91 flacoman91 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates the complaint data download experience and related UI/tooling:

  • Removes JSON as a download option; filtered and full downloads are CSV (full dataset remains a zipped CSV).
  • Redesigned “Download complaint data” modal, clearer dataset options, and filter/limit error alerts when filtered results can’t be downloaded.
  • Prefers filtered results when filters are applied and under the 100k limit; otherwise defaults to all data and disables filtered when it’s empty or over the limit.
  • Copy-link polish - Saves the current results URL; success state uses the secondary button (“Link copied” + check icon) instead of the old green style; input/button join without a gray shared edge.
  • Page-loading overlay - Blocks interaction (including Export) while aggregations/results are refetching so the modal doesn’t open with empty counts.
  • Filter panel layout - Removes extra side padding on expandables and the narratives checkbox so controls use the full panel width.
  • DS/DSR cleanup - Drops redundant local styles covered by the design system; bumps DSR; small tab spacing tweak.
  • TypeScript kickoff - Adds Babel TS + yarn typecheck; converts leaf modules (breakpoints, colors, compare, format-date); prunes unused utils/constants.

Test plan

  • Open Export with no filters → filtered option disabled + empty-filter alert; All selected
  • Apply filters under 100k → Filtered selected and enabled; download CSV
  • Apply filters over 100k → Filtered disabled + limit alert; All selected
  • Copy link → “Link copied” secondary button; URL is the page URL
  • Confirm modal title/copy and Download/Cancel/Close actions
  • While results are loading, Export is blocked by the page overlay
  • Filter panel expandables and narratives checkbox align full-width
  • Unit tests / typecheck pass

Keep JSON available for full-dataset downloads from files.consumerfinance.gov, and update tour copy and tests to match.
Filtered downloads are always CSV, so only show format radios for the full dataset and drop the redundant format from filtered export analytics.
@coveralls

coveralls commented Jul 28, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 88.154%rad-remove-filtered-json-export into main. No base build found for main.

@flacoman91 flacoman91 changed the title Remove JSON format DATAP-2042 - Remove JSON format Jul 28, 2026
@flacoman91

Copy link
Copy Markdown
Contributor Author

Closing. will do this in another pr

@flacoman91 flacoman91 closed this Jul 30, 2026
@flacoman91 flacoman91 reopened this Aug 4, 2026
Resolve data-export conflicts by keeping filtered exports CSV-only
while adopting main's kebab-case format radio ids.
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cfpb.github.io/ccdb5-ui/pr-previews/pr-619/

Built to branch gh-pages at 2026-08-06 06:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

…ches.

Centralize aggregations and view-query loading so Export and filters cannot be used while complaint counts are still resolving.
Align modal width, padding, overlay opacity, and section heading copy with the latest export dialog specs.
Add Babel TS support and a typecheck script, convert breakpoints/colors/compare/format-date, and remove unused utils and constants.
Drop Design System left/right padding on filter expandable headers and content so controls use the full panel width.
Remove horizontal margin on the single-checkbox filter so it matches the full-width expandable filters.
Show “Link copied” with the check icon on the secondary button and remove the green success override.
@flacoman91
flacoman91 marked this pull request as ready for review August 5, 2026 05:58
Switch design-system-react to the npm release and clarify unavailable filtered-download messages, with specs asserting the literal text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants