Repository navigation
fix(ui): close archive Undo dialogs reliably - #871
Merged
Merged
Conversation
Owner
|
Reviewed commit: High
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Chromium archive Undo test could press Escape before the bulk archive flow had mounted the New Chat dialog. CI then observed one dialog still open at
archive-undo.test.ts:55because the Escape event had no registered dialog layer to close.When the New Chat project path had its directory picker open, closing that picker restored focus to the path input, whose focus handler immediately reopened the picker. Escape could not progress to the parent dialog.
Fix
Validation
bun run --cwd web test -- src/lib/components/project-paths/__tests__/ProjectPathField.test.ts(13 passed)bun run --cwd web checkbun run buildbun test --max-concurrency=1 --timeout=180000 tests/chromium/archive-undo.test.ts(1 passed)