persist regenerated config tokens#82
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configinstance is backed by a file pathWhy
A successful live token regeneration currently updates the in-memory config but does not persist
gtokenandbullet_tokenback to disk unless callers remember to invokesave_to_file()separately. That makes expensive successful refreshes easy to lose.Impact
File-backed uses of
Config.regenerate_tokens()now persist refreshed tokens immediately after a successful regeneration. This keeps.splatnet3_scraperaligned with the live token state without changing memory-only callers.Testing
uv run pytest -q tests/query/configuration/test_config.py tests/query/test_queryhandler.py