fix(timeline): unify and clamp cross-platform wheel zoom#866
Open
lukecotter wants to merge 1 commit into
Open
Conversation
The three timeline wheel handlers each used an unbounded linear factor (1 + -deltaY*0.001), which zoomed in large jumps on Windows mice, could go <=0 on fast scrolls, and drifted (in-then-out did not return to the same zoom). Extract one wheelZoomFactor() helper (clamped, exponential) in ViewportUtils and share it across the main, minimap and metric-strip handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Makes timeline mouse-wheel zoom consistent across platforms and input devices. Follow-up to the #863 investigation, where Windows wheel zoom felt jumpy compared with macOS.
🛠️ Changes made
wheelZoomFactor()helper inViewportUtils— clamped per-event delta (so a Windows mouse notch and a macOS trackpad map to the same bounded step) and an exponential factor (always > 0; zoom-in then zoom-out is reciprocal, so no drift).1 + -deltaY * 0.001formula in all three wheel handlers (main flame chart, minimap, metric strip) with the shared helper.This also fixes two latent defects in the old linear formula: a large single delta could produce a
<= 0zoom factor, and repeated in/out scrolling drifted away from the starting zoom.🧩 Type of change (check all applicable)
🔗 Related Issues
related #863
✅ Tests added?
ViewportUtils.test.ts(helper math: direction, positivity, symmetry, clamp, deltaMode, sensitivity) andTimelineInteractionHandler.test.ts(wheel/mouse wiring).📚 Docs updated?