fix(timeline): guard minimap density against fractional display width (#863)#865
Closed
lukecotter wants to merge 1 commit into
Closed
fix(timeline): guard minimap density against fractional display width (#863)#865lukecotter wants to merge 1 commit into
lukecotter wants to merge 1 commit into
Conversation
…certinia#863) Windows fractional display scaling (125/150/175%) makes getBoundingClientRect().width non-integer; passing it to MinimapDensityQuery as a bucket count threw "Invalid array length" and aborted timeline init before interaction handlers attached, so zoom/pan/keys all appeared dead. Floor the count at the single query() entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Main-line copy of the #863 fix (released as 1.20.1 via a separate release-branch PR). On Windows with fractional display scaling (125/150/175%),
getBoundingClientRect().widthis non-integer; passed as a minimap density bucket count it threwRangeError: Invalid array length, abortingFlameChart.init()before interaction handlers attached — so zoom, pan and keyboard all appeared dead.🛠️ Changes made
MinimapDensityQuery.query()entry point (covers both compute paths and the cache key).🧩 Type of change (check all applicable)
🔗 Related Issues
closes #863
✅ Tests added?
NaNbucket-count regression tests inminimap-density.test.ts.📚 Docs updated?