style(tabulator): resolve eslint warnings in test suites#852
Merged
Conversation
- type the tabulator-tables mock Renderer with MockTable/MockRowEl instead of any - rename mock row prop __internal to internalRow to satisfy naming-convention - add braces to single-line if/for bodies flagged by curly
lcottercertinia
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Clears the 9 remaining eslint warnings in the tabulator test/mocks files so
pnpm lintruns clean. No production code or behaviour changes.🛠️ Changes made
tabulator-tablesmockRendererwithMockTable/MockRowElinterfaces instead ofany(no-explicit-any)__internal→internalRowinAnchoringPolicy.test.tsto satisfynaming-convention(double-underscore)if/forbodies flagged by thecurlyrule🧩 Type of change (check all applicable)
✅ Tests added?
The 4 affected suites (83 tests) still pass unchanged.
📚 Docs updated?