Skip to content

Conversation

@SgtCoDFish
Copy link
Member

This helps with helm upgrade use!

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 11, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2026
@erikgb erikgb requested a review from Copilot February 12, 2026 09:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a second OCI tag for the cert-manager Helm chart without the leading v (e.g., 1.14.0 in addition to v1.14.0) to make helm upgrade flows easier when version resolution expects non-v semver tags.

Changes:

  • Derive a non-v version string from RELEASE_VERSION and copy the chart OCI artifact to that tag.
  • Sign the newly created non-v tag with cosign (matching the existing signing flow for the v tag).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 131 to 132
echo "$RELEASE_VERSION is not v-prefixed, skipping copy to non-v-prefixed version"
exit 0
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here uses a tab character, which is inconsistent with the rest of this script. The script uses 2-space indentation throughout (see lines 39-40, 44-45, 76-77). Please change the tab to 2 spaces to maintain consistency.

Copilot uses AI. Check for mistakes.
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant