fix: allow disabling PKCS12 without password

[immanuwell]

What

Tiny PKCS12 papercut fix.

When csi.cert-manager.io/pkcs12-enable: "false" is set, the driver should treat PKCS12 as disabled. Before this, defaulting still added pkcs12-filename, and validation then asked for pkcs12-password. thats a bit awkward ngl.

Repro

Use volume attributes like:

csi.cert-manager.io/issuer-name: ca-issuer
csi.cert-manager.io/key-encoding: PKCS8
csi.cert-manager.io/pkcs12-enable: "false"

Before this change WriteKeypair fails with:

volumeAttributes.csi.cert-manager.io/pkcs12-password: Required value: required attribute when PKCS12 KeyStore is enabled

The new test covers that case. It also keeps the existing enabled path intact.

Test

go test -count=1 ./cmd/... ./pkg/...

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hjoshi123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cert-manager-prow]

Hi @immanuwell. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[SgtCoDFish]

suggestion: this is a sharp edge if anyone set the value to "TRUE" or similar. Could we lowercase the attribute?

Suggested change

	if attr[csiapi.KeyStorePKCS12EnableKey] == "true" {
	if strings.ToLower(attr[csiapi.KeyStorePKCS12EnableKey]) == "true" {

[SgtCoDFish]

/ok-to-test