Skip to content

rgw: add checksum type and algorithm in S3 APIs #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sungjoon-koh wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rgw: add checksum type and algorithm in S3 APIs #712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9b3117
rgw: check checksum algo/type for list parts
sungjoon-koh Dec 4, 2025
6546d78
rgw: check checksum algo/type for create mp upload
sungjoon-koh Dec 4, 2025
3f1777c
rgw: check checksum algo/type for listobjects
sungjoon-koh Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions s3tests/functional/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5880,6 +5880,9 @@ def _multipart_upload_checksum(bucket_name, key, size, part_size=5*1024*1024, cl
response = client.create_multipart_upload(Bucket=bucket_name, Key=key, Metadata=metadata, ContentType=content_type,
ChecksumAlgorithm='SHA256')

assert response['ChecksumAlgorithm'] == 'SHA256'
assert response['ChecksumType'] == 'COMPOSITE'

upload_id = response['UploadId']
s = ''
parts = []
Expand All @@ -5900,6 +5903,16 @@ def _multipart_upload_checksum(bucket_name, key, size, part_size=5*1024*1024, cl
client.upload_part(UploadId=upload_id, Bucket=bucket_name, Key=key, PartNumber=part_num, Body=part,
ChecksumAlgorithm='SHA256')

response = client.list_parts(UploadId=upload_id, Bucket=bucket_name, Key=key)

listed_parts = response['Parts']
for part in listed_parts:
part_number = part['PartNumber']
assert part['ChecksumSHA256'] == part_checksums[part_number - 1]

assert response['ChecksumAlgorithm'] == 'SHA256'
assert response['ChecksumType'] == 'COMPOSITE'

return (upload_id, s, parts, part_checksums)

@pytest.mark.copy
Expand Down Expand Up @@ -14683,6 +14696,7 @@ def multipart_checksum_3parts_helper(key=None, checksum_algo=None, checksum_type

response = client.create_multipart_upload(Bucket=bucket, Key=key, ChecksumAlgorithm=checksum_algo, ChecksumType=checksum_type)
assert checksum_algo == response['ChecksumAlgorithm']
assert checksum_type == response['ChecksumType']
upload_id = response['UploadId']

cksum_arg_name = "Checksum" + checksum_algo
Expand All @@ -14702,6 +14716,16 @@ def multipart_checksum_3parts_helper(key=None, checksum_algo=None, checksum_type
etag3 = response['ETag'].strip('"')
cksum3 = response[cksum_arg_name]

response = client.list_parts(UploadId=upload_id, Bucket=bucket, Key=key)
part_checksums = [cksum1, cksum2, cksum3]
listed_parts = response['Parts']
for part in listed_parts:
part_number = part['PartNumber']
assert part[cksum_arg_name] == part_checksums[part_number - 1]

assert response['ChecksumAlgorithm'] == checksum_algo
assert response['ChecksumType'] == checksum_type

upload_args = {cksum_arg_name : kwargs['composite_cksum']}
response = client.complete_multipart_upload(Bucket=bucket, Key=key, UploadId=upload_id, MultipartUpload={'Parts': [
{'ETag': etag1, cksum_arg_name: cksum1, 'PartNumber': 1},
Expand All @@ -14725,6 +14749,14 @@ def multipart_checksum_3parts_helper(key=None, checksum_algo=None, checksum_type
assert response3['Checksum']['ChecksumType'] == checksum_type
assert response3['Checksum'][cksum_arg_name] == kwargs['composite_cksum']

response = client.list_objects(Bucket=bucket)
response['Contents'][0]['ChecksumAlgorithm'] = [checksum_algo]
response['Contents'][0]['ChecksumType'] = checksum_type

response = client.list_objects_v2(Bucket=bucket)
response['Contents'][0]['ChecksumAlgorithm'] = [checksum_algo]
response['Contents'][0]['ChecksumType'] = checksum_type

@pytest.mark.checksum
@pytest.mark.fails_on_dbstore
def test_multipart_use_cksum_helper_sha256():
Expand Down