TA-3754: Simplify ContentService#212
Merged
Zgjim Haziri (ZgjimHaziri) merged 7 commits intoJun 16, 2025
Merged
Conversation
Zgjim Haziri (ZgjimHaziri)
requested review from
a team,
Dusan Radosavljevic (Dusan-r),
Ekta Dubey (EktaCelonis),
Ivan Gandacov (IvanGandacov) and
Oleg Goras (gorasoCelonis)
as code owners
Buqeta (Buqeta)
approved these changes
Jun 13, 2025
Jeta (jetakasabaqi)
previously approved these changes
Jun 13, 2025
Kastriot Salihu (ksalihu)
approved these changes
Jun 13, 2025
Kastriot Salihu (ksalihu)
previously approved these changes
Jun 13, 2025
Buqeta (Buqeta)
previously approved these changes
Jun 13, 2025
Base automatically changed from
TA-3754-minor-refactoring
to
content-cli-v2-refactoring
June 16, 2025 08:28
Zgjim Haziri (ZgjimHaziri)
dismissed stale reviews from Buqeta (Buqeta), Kastriot Salihu (ksalihu), and Jeta (jetakasabaqi)
The base branch was changed.
Zgjim Haziri (ZgjimHaziri)
requested review from
Buqeta (Buqeta),
Jeta (jetakasabaqi) and
Kastriot Salihu (ksalihu)
Buqeta (Buqeta)
approved these changes
Jun 16, 2025
Kastriot Salihu (ksalihu)
approved these changes
Jun 16, 2025
Zgjim Haziri (ZgjimHaziri)
merged commit 8ea093c
into
content-cli-v2-refactoring
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ContentServicewas reduced because no custom logic was provided there except for calling the push/pull methods of the sentBaseManager.batchPushmethod of theContentServiceseemed to be useful as a helper method, so extracted it in aBaseManagerHelperclass.Relevant links
Jira issue: https://celonis.atlassian.net/browse/TA-3754
Checklist