Skip to content

test(p2p): provide tail in partial range store - #409

Open
loglapa wants to merge 1 commit into
celestiaorg:mainfrom
loglapa:fix/partial-range-store-tail
Open

test(p2p): provide tail in partial range store#409
loglapa wants to merge 1 commit into
celestiaorg:mainfrom
loglapa:fix/partial-range-store-tail

Conversation

@loglapa

@loglapa loglapa commented Aug 21, 2026

Copy link
Copy Markdown

Follow-up to #406.

handleRangeRequest now queries Tail before checking the requested range. The focused partialRangeStore test double embedded a nil header.Store, so its inherited Tail method panicked and made the current main test suite fail deterministically.

Give the test double an explicit tail at the requested lower bound and implement Tail, preserving the original test path: the range is not below tail, HasAt remains false, and the assertion still verifies that to is not expanded to the distant head.

Validation

  • go test ./...
  • go vet ./...
  • golangci-lint run
  • go test ./p2p -run ^'TestExchangeServer_partialRangeNotExpanded$' -count=100\n- go test -race ./p2p -run ^'TestExchangeServer_partialRangeNotExpanded$' -count=20\n- docker run --rm -v "$PWD:/workspace" -w /workspace golang:1.27 go test ./...

@loglapa
loglapa marked this pull request as ready for review August 23, 2026 08:03
@loglapa
loglapa requested a review from a team as a code owner August 23, 2026 08:03
@loglapa
loglapa requested a review from vgonkivs August 23, 2026 08:03
@vgonkivs
vgonkivs enabled auto-merge (squash) August 24, 2026 12:48
@mergify

mergify Bot commented Aug 24, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@loglapa

loglapa commented Aug 24, 2026

Copy link
Copy Markdown
Author

@Mergifyio queue

@mergify

mergify Bot commented Aug 24, 2026

Copy link
Copy Markdown

queue

☑️ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission >= write

@loglapa

loglapa commented Aug 24, 2026

Copy link
Copy Markdown
Author

The branch is current with main and the PR is approved. The remaining build failure occurs in CI setup before this test runs: golangci-lint panics because a dependency file requires Go 1.27 while the application was built with Go 1.26. I attempted both a failed-job rerun and the merge-queue command; GitHub restricts reruns to repository admins and Mergify restricts queueing to users with write permission. A maintainer rerun/queue after the runner toolchain is aligned is the remaining action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants