test(store): wait for append before checking head - #408
Closed
loglapa wants to merge 1 commit into
Closed
Conversation
Member
|
Please stop pass by PRs. |
Author
|
Hi @rach-id. I understand the concern about drive-by contributions, but I’d appreciate a more specific explanation for closing this PR. This is a one-line, test-only change backed by a reproduced failure (3/200 runs), 500 successful focused runs after the fix, race testing, vet, and lint. I’m available to address review feedback and maintain the contribution. If there is a repository process I missed, such as obtaining approval before starting an issue, please point me to it and I’ll follow it going forward. Otherwise, could you please reconsider reopening the PR or provide the technical/process reason why this contribution should not proceed? I’ll pause new go-header contributions until this is clarified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stabilizes
TestStoreby waiting for the asynchronous append pipeline before asserting the contiguous head.Store.Appendintentionally returns after enqueueing writes (see #244), andGetRangecan observe pending headers beforeadvanceHeadupdatescontiguousHead; the previous test therefore compared the new range with the old head intermittently.The production behavior is unchanged.
Validation
go test ./storego test -race ./storego vet ./...golangci-lint run(0 issues)git diff --checkThe repository-wide suite is currently blocked on an unrelated deterministic panic introduced on
mainby merged #406 (TestExchangeServer_partialRangeNotExpandedcalls the newly requiredTailmethod through a nil embedded store). It reproduces on both Go 1.26/darwin and Go 1.27/linux; details are posted on #406. This PR changes onlystore/store_test.go.