Skip to content

test(share): cover RowsWithNamespace boundaries - #5194

Open
loglapa wants to merge 2 commits into
celestiaorg:mainfrom
loglapa:test/rows-with-namespace-3430
Open

test(share): cover RowsWithNamespace boundaries#5194
loglapa wants to merge 2 commits into
celestiaorg:mainfrom
loglapa:test/rows-with-namespace-3430

Conversation

@loglapa

@loglapa loglapa commented Aug 22, 2026

Copy link
Copy Markdown

Closes #3430

Summary

  • cover inclusive minimum and maximum namespace boundaries
  • cover overlapping rows, single-namespace rows, and namespaces outside all rows
  • verify malformed row roots fail without returning partial matches
  • fuzz row-range selection against a simple reference predicate

Validation

  • go test ./share -count=1
  • go test -race ./share -run TestRowsWithNamespace -count=1
  • go test ./share -run '^$' -fuzz '^FuzzRowsWithNamespace$' -fuzztime=5s (218k+ executions)
  • golangci-lint run ./share

@github-actions github-actions Bot added the external Issues created by non node team members label Aug 22, 2026
@loglapa
loglapa marked this pull request as ready for review August 22, 2026 12:00
@loglapa
loglapa requested review from a team and vgonkivs as code owners August 22, 2026 12:00
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown

Greptile Summary

Adds focused unit and fuzz coverage for namespace-to-row matching, including inclusive boundaries, empty roots, malformed row roots, and generated ordered namespace ranges. The new deterministic tests and fuzz run completed successfully without revealing a behavioral failure.

Confidence Score: 5/5

No blocking failure remains.

The focused boundary, malformed-input, and fuzz coverage completed successfully, and no accepted blocking finding remains.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex completed the requested verification of the proof-of-work for the pull request.
  • T-Rex noted that local artifact references were not uploaded as part of the verification.

T-Rex Ran code and verified through T-Rex

Reviews (3): Last reviewed commit: "test(share): fix import grouping" | Re-trigger Greptile

Comment thread share/root_test.go Outdated
Vladislav Lapin added 2 commits August 24, 2026 18:09
Signed-off-by: Vladislav Lapin <v.lapin@scalablesolutions.io>
Signed-off-by: Vladislav Lapin <v.lapin@scalablesolutions.io>
@loglapa
loglapa force-pushed the test/rows-with-namespace-3430 branch from 45abe9a to f80f1dd Compare August 24, 2026 14:10
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.71%. Comparing base (2469e7a) to head (f80f1dd).
⚠️ Report is 895 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5194      +/-   ##
==========================================
- Coverage   44.83%   37.71%   -7.12%     
==========================================
  Files         265      308      +43     
  Lines       14620    21409    +6789     
==========================================
+ Hits         6555     8075    +1520     
- Misses       7313    12310    +4997     
- Partials      752     1024     +272     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Issues created by non node team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(share): Add unit tests for RowsWithNamespace

2 participants