perf(nodebuilder/config): Increase PeersLimit based on DASer ConcurrencyLimit

[renaynay]

Increasing the PeersLimit will help bridge nodes have a better chance of maintaining better performing peers in its node pool instead of arbitrarily limiting the # of peers it can discover.

TODO:

• potentially decouple archival peers lim from full

[codecov-commenter]

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.67%. Comparing base (2469e7a) to head (50a580c).
⚠️ Report is 882 commits behind head on main.

Files with missing lines	Patch %	Lines
nodebuilder/share/p2p_constructors.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
- Coverage   44.83%   37.67%   -7.17%     
==========================================
  Files         265      307      +42     
  Lines       14620    21349    +6729     
==========================================
+ Hits         6555     8043    +1488     
- Misses       7313    12294    +4981     
- Partials      752     1012     +260     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[greptile-apps]

Greptile Summary

The change increases the generic discovery peer default and derives full-node discovery capacity from DASer concurrency while retaining an archival-specific cap. The published SHREX discovery documentation still states a generic default of 5 even though the runtime default is 10, which can mislead operators planning peer and resource capacity.

Confidence Score: 4/5

Not ready to merge until the SHREX discovery default documentation reflects the behavior introduced by this change.

One non-security P2 finding remains after executable verification, so the required score is 4.

Files Needing Attention: specs/src/shrex/shrex.md needs its generic discovery peer-limit default updated and should distinguish the archival-specific cap.

T-Rex Logs

What T-Rex did

• T-Rex produced proof for a posted P2 finding.
• T-Rex linked the produced proof to the review comment that contains the P2 finding details.

_{Ran code and verified through T-Rex}

Comments Outside Diff (1)

1. specs/src/shrex/shrex.md, line 573 (link)

   Discovery default documentation is stale

   The generic SHREX discovery parameters still document PeersLimit with a default of 5, but discovery.DefaultParameters() now returns 10. Full-node configuration uses that generic default (and derives a value no lower than 10), whereas the archival five-peer limit is a separate override. Update the specification to describe the current generic/full-node default and distinguish the archival cap if it is intended to remain 5.

   _{Ran code and verified through T-Rex}

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: specs/src/shrex/shrex.md
   Line: 573
   
   Comment:
   **Discovery default documentation is stale**
   
   The generic SHREX discovery parameters still document `PeersLimit` with a default of 5, but `discovery.DefaultParameters()` now returns 10. Full-node configuration uses that generic default (and derives a value no lower than 10), whereas the archival five-peer limit is a separate override. Update the specification to describe the current generic/full-node default and distinguish the archival cap if it is intended to remain 5.
   
   ---
   
   For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

   Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI

### Issue 1
specs/src/shrex/shrex.md:573
**Discovery default documentation is stale**

The generic SHREX discovery parameters still document `PeersLimit` with a default of 5, but `discovery.DefaultParameters()` now returns 10. Full-node configuration uses that generic default (and derives a value no lower than 10), whereas the archival five-peer limit is a separate override. Update the specification to describe the current generic/full-node default and distinguish the archival cap if it is intended to remain 5.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "perf(nodebuilder/config): Increase Peers..." | Re-trigger Greptile}

[vgonkivs]

could you please update shrex.md, updating new peer limit default