This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
chore(solid-start): Solid rc.10 + vite-plugin next.46(草稿:todos store 回归待查) - #3
Merged
Merged
Conversation
…: todos store regressions)
…/solid#3687) Two todos store scenarios fail on Solid 2.0.0-rc.10 because the attribution engine (captureArtifact) stops a failed action from reverting an optimistic store. They are it.fails with the issue link, so they turn red once upstream fixes it; the engine's revert check also throws an unhandled rejection in this file, which keeps the run failing until then.
Contributor
Author
|
暂缓升级,继续保持 Draft。已评估 Solid 2.0.0-rc.13,但目前还没有足够证据确认它在我们的 SSR/水合路径上可以安全替代当前版本。 本轮验证结果:
仍需关注的 SSR/水合问题:
决策:本轮不升级、不合并,不以关闭 attribution 后的单测通过作为放行依据。对 optimistic store 的修复不足以抵消目前 SSR/水合行为仍未验证的风险。待相关上游修复或进一步证据到位,再在隔离环境中复查慢查询/流式水合期间导航、后续连续导航、SSR 失败响应和现有业务回归用例。 后续若重启 RC13 验证,需要同步升级运行时、signals、web、diagnostics 与编译器/vite-plugin(本轮验证使用 next.47,router next.32)。RC12 未实际发布,其变更包含在 RC13 中。本轮未修改本 PR 分支、主 checkout 或部署。 |
It is not mature yet: RC10's cost checks flood dev pages, and an optimistic store fails to revert while the engine is on (solidjs/solid#3687). - vite: performanceTracks false for the web app and the extension (the tracks hold the engine; dev-serve only) - tests: captureArtifact runs with attribution false; the two it.fails cases are ordinary tests again and the suite exits 0. Diagnostics assertions do not need the engine.
ethan-huo
marked this pull request as ready for review
September 30, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
与 celados/delta#56 同步:solid-start 和 extension 都升级到 Solid 2.0.0-rc.10(web、diagnostics 同步),vite-plugin 升到 next.46,两份 lockfile 一起更新。typecheck 和 web 构建都通过。
被上游回归卡住:solidjs/solid#3687。attribution 引擎开着时(
captureArtifact,或 vite-plugin next.46 在 dev 下默认开启的 performance tracks),失败的 action 不会回滚createOptimisticStore;rc.9 正常,createOptimistic不受影响,生产环境不受影响。web/src/lib/todos.test.tsx里受影响的 2 个用例改为it.fails并附链接:上游修好后它们会失败,提醒我们改回it(),不会被静默跳过。_host,调用栈已追加到上游 issue),所以在上游修好之前这个测试文件的运行结果仍然是失败的。it()、重跑并合并。2026-09-30:关闭 attribution,解除阻塞
dio 定:attribution 引擎现阶段不成熟,先关掉,等成熟再开。
performanceTracks: false。性能轨道功能内部持有 attribution 引擎,这个选项只影响vite dev。captureArtifact统一传attribution: false。断言用的是诊断通道,不依赖这个引擎。it.fails用例恢复为普通用例:13 个全部通过,退出码 0,_host的未处理异常消失。attribution: false去掉,它会重新以_host失败,证明起作用的是这个开关。bun run check通过(web 13 个、extension 24 个测试)。不再等 rc.12:上游 bug(solidjs/solid#3687)只在引擎开启时触发。