Skip to content

Add string set membership optimization for constant string lists. #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 27, 2026
Merged

Add string set membership optimization for constant string lists. #2399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eval/eval/evaluator_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ class ExpressionStep {
return header_.id >= 0 ? static_cast<int64_t>(header_.id) : -1;
}

ExpressionStepKind kind() const { return header_.kind; }

// Returns if the execution step comes from AST.
bool comes_from_ast() const { return header_.id >= 0; }

Expand Down
6 changes: 6 additions & 0 deletions extensions/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,16 +883,22 @@ cc_library(
"//common:expr",
"//common:native_type",
"//common:standard_definitions",
"//common:type",
"//common:value",
"//common/internal:attribute_trail",
"//eval/compiler:flat_expr_builder",
"//eval/compiler:flat_expr_builder_extensions",
"//eval/eval:evaluator_core",
"//eval/eval:expression_step_base",
"//internal:casts",
"//internal:status_macros",
"//runtime",
"//runtime:runtime_builder",
"//runtime/internal:errors",
"//runtime/internal:runtime_friend_access",
"//runtime/internal:runtime_impl",
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/hash",
"@com_google_absl//absl/log:absl_check",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
Expand Down
Loading
Loading