Repository navigation
kommand: recognise missing commands on newer JDKs, skip sudo password… - #2
Closed
AkitoTheGambler wants to merge 1 commit into
Closed
AkitoTheGambler wants to merge 1 commit into
AkitoTheGambler wants to merge 1 commit into
Conversation
… test without password prompt
There was a problem hiding this comment.
🟡 Changes recommended
The sudo probe does not match the tested invocation, so cached credentials or command-specific policies can still cause test failures.
1 open issue
What changed in this PR
This PR aims to make kommand builds more reliable across JDK versions and local sudo configurations.
Changes:
- Recognizes missing-command errors across different JDK message formats.
- Adds a sudo probe to skip the incorrect-password test when authentication is not required.
| File | Description |
|---|---|
kommand/src/test/kotlin/io/github/manamiproject/kommand/JavaProcessBuilderTest.kt |
Adds a password-requirement probe and test assumption. |
kommand/src/main/kotlin/io/github/manamiproject/kommand/JavaProcessBuilder.kt |
Broadens matching of missing-command error messages. |
Review effort: Balanced
Comment on lines
+229
to
+233
| // -k ignores cached credentials, -n fails instead of asking if a password is required | ||
| ProcessBuilder("sudo", "-k", "-n", "true") | ||
| .redirectErrorStream(true) | ||
| .start() | ||
| .waitFor() != 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for kommand:test when running .\gradlew build