Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
values.extend(values)on a nonemptyBoxListkeeps appending because the loop also visits the values it has just added. A regular Python list appends its original contents once and returns.Take a snapshot only when the input is the destination list itself, then use the existing append path. This keeps container conversion and list options in place. Other iterables remain lazy, including their existing partial-progress behavior if iteration raises an error.
Tests cover empty lists, scalar and nested values, and an iterator that fails after yielding a value. The self-extension tests bound the number of appends so they fail safely before the fix. Three cases fail on the unchanged base. All 164 tests pass with both pure Python and the compiled Cython extension on Windows with Python 3.12; mypy, changed-file formatting, package builds and Twine checks also pass. Other Python versions and operating systems were not run locally.