Repository navigation
Conversation
Option b for the MP44 beside cut_part's option a: the barrel stays on its row and the gun shrinks until what hangs below ends inside the rect. No icon sets it yet; output stays VERSION 13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: none
Part of #841. The MP44 (StG) kill-feed icon's magazine is cut off at the bottom of its rect. The gun sits at Valve's width with its barrel on Valve's line, and its real magazine is 7 stock rows longer than the rect leaves room for, so
cut_belowcuts it flat at the edge. This PR adds a table field so that either fix is one line inICONS. The user picks a or b. Until then the table is unchanged and the output stays VERSION 13.cut_part.d_mp44:barrel_top=7, cut_below=True, cut_part=(45, 60, 19). Same size, the magazine ends 4 rows above the edge, and the outline goes round the cut.Icon.shrink_below.d_mp44:barrel_top=7, shrink_below=True. The barrel stays on its row and the gun shrinks until the full curved magazine fits: 71% of today's size. (place_barrel(..., shrink=True).)When the pick is made, set the line, bump VERSION to 14, and repaint POST.
Review sheets (scale 2.5, dark and in-game backgrounds, with 3x zooms):
local\review-images\841\stg-fit\(0_now.png,option_a_shorter_magazine.png,option_b_whole_gun_smaller.png,mp40_options.png, README.md).Other icons that run past their rect (all 35 checked)
cut_part=(57, 68, 19)if it should match option a.Decisions
cut_below=False, 80% size, barrel at the top of the rect) is shown as b2 on the sheet for comparison.shrink_belowwins overcut_belowwhen both are set.Test done
python -m unittest test_killfeed_icons: 57 tests OK, including the newplace_barrelshrink test and a "no icon shrinks by default" test.🤖 Generated with Claude Code