Skip to content

Kill feed: two ways to fit the MP44's magazine in its icon, ready for a pick (part of #841) - #995

Closed
ccoventry wants to merge 5 commits into
devfrom
fix/killfeed-stg-fit-841
Closed

ccoventry wants to merge 5 commits into
devfrom
fix/killfeed-stg-fit-841

Conversation

@ccoventry

Copy link
Copy Markdown
Owner

Release note: none

Part of #841. The MP44 (StG) kill-feed icon's magazine is cut off at the bottom of its rect. The gun sits at Valve's width with its barrel on Valve's line, and its real magazine is 7 stock rows longer than the rect leaves room for, so cut_below cuts it flat at the edge. This PR adds a table field so that either fix is one line in ICONS. The user picks a or b. Until then the table is unchanged and the output stays VERSION 13.

  • Option a, shorter magazine: the existing cut_part. d_mp44: barrel_top=7, cut_below=True, cut_part=(45, 60, 19). Same size, the magazine ends 4 rows above the edge, and the outline goes round the cut.
  • Option b, the whole gun smaller: new Icon.shrink_below. d_mp44: barrel_top=7, shrink_below=True. The barrel stays on its row and the gun shrinks until the full curved magazine fits: 71% of today's size. (place_barrel(..., shrink=True).)

When the pick is made, set the line, bump VERSION to 14, and repaint POST.

Review sheets (scale 2.5, dark and in-game backgrounds, with 3x zooms): local\review-images\841\stg-fit\ (0_now.png, option_a_shorter_magazine.png, option_b_whole_gun_smaller.png, mp40_options.png, README.md).

Other icons that run past their rect (all 35 checked)

  • MP40: magazine 8 rows past the bottom, cut the same way. Proposal: leave it, since it already reads as a short magazine and b would make it 67% size. cut_part=(57, 68, 19) if it should match option a.
  • 30cal: bipod 7 rows past the bottom, which the user's earlier review chose. Leave it.
  • britgrenade, greasegun, enfield, garand, piat: 1 texel at 4x into the outline margin. Can't be seen.

Decisions

  • No table entry changed and VERSION not bumped, so nothing changes until the user picks. Nothing installed in POST.
  • Option b keeps the barrel on Valve's line rather than raising it. The existing raise-to-fit behaviour (cut_below=False, 80% size, barrel at the top of the rect) is shown as b2 on the sheet for comparison.
  • shrink_below wins over cut_below when both are set.

Test done

  • python -m unittest test_killfeed_icons: 57 tests OK, including the new place_barrel shrink test and a "no icon shrinks by default" test.
  • Offline renders of all 35 icons from POST's models, plus the MP44 at cut rows 15/17/19/21, shrink and b2, and the MP40 and 30cal variants. The clip report compares each model's whole silhouette at its final fit with the rect.
  • Not seen in game: neither option is painted on POST.

🤖 Generated with Claude Code

Option b for the MP44 beside cut_part's option a: the barrel stays on
its row and the gun shrinks until what hangs below ends inside the rect.
No icon sets it yet; output stays VERSION 13.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ccoventry

Copy link
Copy Markdown
Owner Author

On hold: superseded by #1022's R2 (26-row boxes, nothing cut), which the user picked over cutting the MP44/MP40/30cal/Thompson magazines. Close this PR once #1022's build PR is open.

@ccoventry

Copy link
Copy Markdown
Owner Author

Closed: superseded by #1023 (#1022's even layout, picked over cutting the magazines).

@ccoventry ccoventry closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant