Repository navigation
Start Capture Batch greys out and says which check it's on before the batch starts (#953) - #969
Merged
Merged
Conversation
) The click ran OBS, disk, demo, map, path, game and Steam checks with Start still live and nothing on the footer. capture_precheck.js greys Start out and slides the footer bar from the click, puts each check on the status line ("Checking the picked demos are where they were (3 of 12)…"), and on a stop brings Start back with the reason. refreshLaunchGuard leaves Start greyed out while the checks run. changed_demos emits changed_demos_progress (33 ms throttle, always the last demo) for the count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Changed: Start Capture Batch greys out the moment it's clicked and says which check it's on (OBS, disk space, the picked demos, maps, Steam) until the batch starts.
Closes #953. From the #942 progress audit (plan C).
What changes
studio/src/capture_precheck.js(createCapturePrecheck): on the click, Start greys out, the footer bar shows with the sliding block, and the status line reads each check as it runs:refreshLaunchGuard, so the disk-space guard still has the last word) and puts the reason on the line: the same text as its toast, the existing "Not started — …" lines for Steam and a game with other settings, or "Not started." when a question was answered no.refreshLaunchGuardno longer re-enables Start while the checks run (it's called by the disk check itself and by every settings edit).changed_demos(lib.rs) now emitschanged_demos_progress{ done, total }, throttled to ~33 ms with the last demo always sent, for the "3 of 12" count.changedDemos(demos, onProgress)inipc_bridge.jslistens only while it runs;captureDemosReady/pickedDemosPresentpassonProgressthrough.Decisions
capture_status). This PR touches only the click handler and therefreshLaunchGuardguard incapture_pane.js; Render while capturing: each clip renders as soon as it's recorded, and a long batch waits for space instead of filling the drive (#861) #885's hunks are elsewhere in the file. The handler body moved into arunChecksAndStartarrow at the same indent, so the diff stays small..progress-bar-container.indeterminate. It can move toprogress_view.jsonce Master Queue scan: show progress while it looks for demos, and one bar through grouping and splits #951 lands.Test done
npm run test:unit: 79 files, 714 tests pass (newcapture_precheck.test.js: each line, the count, begin/stop/hand-over on fake elements).CI=1 npx playwright teston the newcapture-precheck.spec.js(4) plus master-pane, queue-scan, split-maps, running-game and recent-projects: 39 pass. The new spec runs the realinitCaptureUI. It checks that Start greys out and the line reads "Checking the disk space…" while that check is still held (the first line shows at once). It checks that the demo check's count shows, that a second click and a guard refresh leave Start greyed out, that a missing demo brings Start back with the reason and hides the bar, and that a "no" says "Not started."npm run build: ok.cargo test -p desktop-studio: 185 pass (new: the per-demo count, and the throttle that always sends the last demo).cargo fmt --all --checkand clippy 1.98.1-p desktop-studio --all-targets -D warnings: clean.🤖 Generated with Claude Code