Skip to content

Overview stair areas, OBS take deletion and console-log read: three small fixes (part of #1252, #1255) - #1262

Merged
ccoventry merged 2 commits into
devfrom
fix/small-leftovers-after-1252-1255
Oct 31, 2026
Merged

ccoventry merged 2 commits into
devfrom
fix/small-leftovers-after-1252-1255

Conversation

@ccoventry

Copy link
Copy Markdown
Owner

Release note: Fixed: deleting an OBS take now also removes its leftover state file, so the take's folder is cleared whole.

Three small leftovers from reviews of #1252 and #1255.

  • overview/scene.rs: the stair-tread/ledge area vote built neighbour cell numbers as i*ny+j±1, so at a column edge it read the next or previous column's cell. New beside_cells leaves out-of-range j. Test beside it.
  • hlcr/take_delete.rs: dodstudio_obs_take.json is per-take state, not history. Deleting a take (Recycle Bin or permanent) now includes it: from inside a folder that keeps dodstudio_take.json, and the block folder's copy when a take0000 is deleted. History file stays. Test added.
  • catch_up_takes.rs: read_console_log uses String::from_utf8 with a lossy fallback, so a valid 64 MB tail is not copied. Test for bad bytes added.

Decisions

  • Item 4 (stale comments from open-items section 5): checked each on dev; all are already fixed (docs/commands panel_toggles path, detail_pane.js, packet_limit_manager.rs, obs_connection_ui.js, engine.rs "ten", renderer.rs, setting.rs, Cargo.toml too_many_arguments, hires_log doc). No comment PR needed.

Test done

fmt (1.98.1), clippy workspace --all-targets -D warnings clean; cargo test --workspace --locked --exclude goldsrc-hooks --exclude web-analyzer: 1930 passed, 0 failed. No game launched.

🤖 Generated with Claude Code

- Overview: a small floor face no longer takes its area from the first cell of the next (or last of the previous) grid column.
- Deleting a take removes its OBS state file with it; history stays.
- The console log tail is moved into a String without a copy when it is valid UTF-8.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ccoventry
ccoventry merged commit 982aa2f into dev Oct 31, 2026
6 checks passed
@ccoventry
ccoventry deleted the fix/small-leftovers-after-1252-1255 branch October 31, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant