Repository navigation
Overview stair areas, OBS take deletion and console-log read: three small fixes (part of #1252, #1255) - #1262
Merged
Merged
Conversation
- Overview: a small floor face no longer takes its area from the first cell of the next (or last of the previous) grid column. - Deleting a take removes its OBS state file with it; history stays. - The console log tail is moved into a String without a copy when it is valid UTF-8. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: deleting an OBS take now also removes its leftover state file, so the take's folder is cleared whole.
Three small leftovers from reviews of #1252 and #1255.
overview/scene.rs: the stair-tread/ledge area vote built neighbour cell numbers asi*ny+j±1, so at a column edge it read the next or previous column's cell. Newbeside_cellsleaves out-of-rangej. Test beside it.hlcr/take_delete.rs:dodstudio_obs_take.jsonis per-take state, not history. Deleting a take (Recycle Bin or permanent) now includes it: from inside a folder that keepsdodstudio_take.json, and the block folder's copy when atake0000is deleted. History file stays. Test added.catch_up_takes.rs:read_console_logusesString::from_utf8with a lossy fallback, so a valid 64 MB tail is not copied. Test for bad bytes added.Decisions
Test done
fmt (1.98.1), clippy workspace --all-targets -D warnings clean;
cargo test --workspace --locked --exclude goldsrc-hooks --exclude web-analyzer: 1930 passed, 0 failed. No game launched.🤖 Generated with Claude Code