Repository navigation
A disk mounted as a folder gets its free space counted on its own (#1041) - #1104
Merged
Merged
Conversation
volume_key names a drive-letter path's volume (GetVolumePathNameW + GetVolumeNameForVolumeMountPointW), falling back to the drive or share prefix; take_cleanup's volume_of goes through it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
Results of the overnight check (unattended pass, 2026-10-29)Merged Tests
Live test with a real folder mount (debug build of this branch in a real Tauri window, own settings folder): the test volume is a VHD mounted at
Verdict: ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: a disk mounted as a folder inside another drive now has its free space counted on its own, so capture and render don't treat it as the drive around it.
Closes #1041
What changes
sys::disk::volume_keykeys a drive-letter path by its Windows volume name (\\?\volume{guid}\):GetVolumePathNameWfinds the mount point the path is under (its nearest existing folder decides, so a folder not made yet still keys by the volume it'll be on), thenGetVolumeNameForVolumeMountPointWnames that volume. SoD:\Capturesmounted from a second disk keys apart fromD:. Two folders on one plain drive still share one key.c:,\\server\share) when Windows has no volume name: a network share (deliberately not asked, since an offline share would wait on the network), asubstdrive, or a drive letter that isn't there.build_batch_queue's per-drive budgets (group_by_volume), the render reservations (ledger_key), the Capture footer's pool total (export_pool_space), and the take cleanup'svolume_of(Delete finished takes automatically: Recycle Bin or permanent, optionally only when space is needed (part of #644) #716), which had its own copy of the prefix rule.get_available_bytes), so it was right for a mounted folder; only the grouping was wrong.refreshSameDriveWarning) still compares drive letters.Test done
a_drive_keys_by_its_volume_name: the system drive keys as\\?\volume{…}, a folder that doesn't exist on it keys the same, a missing drive letter keys as the letter. Updated the two tests that compared against the literalc:/d:.cargo test -p native -p desktop-studiopass; clippy 1.98.1 + fmt clean.mountvol/Disk Management) needs admin.🤖 Generated with Claude Code