Repository navigation
Fix builds: Add GitHub remote for noctua, add Carto API key, and upgrade R pre-commit hooks - #106
Conversation
| paleolimbot/geoarrow, | ||
| ropensci/tabulapdf | ||
| ropensci/tabulapdf, | ||
| DyfanJones/noctua@*release |
There was a problem hiding this comment.
The @*release suffix ensures that the dependency resolver will install the latest release of this package, not the latest commit (docs). I think this is the right move for the sake of stability. I'm assuming we don't do this for tabulapdf because that project does not seem to consistently use releases; I'm not sure why we don't do it for geoarrow, though I plan to strip out that package as soon as we've finalized our migration to sfarrow in data-architecture (ccao-data/data-architecture#1116), so I'm not going to bother changing it right now.
| geoarrow, | ||
| ggplot2, | ||
| ggspatial, | ||
| ggspatial (>= 1.1.11), |
There was a problem hiding this comment.
ggspatial 1.1.11 added support for Carto API keys. See the release notes.
noctua to fix installs, and upgrade R pre-commit hooksnoctua, add Carto API key and upgrade R pre-commit hooks
noctua, add Carto API key and upgrade R pre-commit hooksnoctua, add Carto API key, and upgrade R pre-commit hooks
|
|
||
| <summary><strong>Click here</strong> to show plot code</summary> | ||
| ```{python, eval = FALSE, python.reticulate = FALSE} | ||
| import os |
There was a problem hiding this comment.
praise: Thank you for thinking to add this despite this code chunk not actually running! Continually amazed by your attention to detail.
kyrasturgill
left a comment
There was a problem hiding this comment.
All makes sense to me - thanks for staying on top of these!
This PR fixes three small issues that are causing builds to fail:
noctuapackage has been temporarily removed from CRAN; see package removed from CRAN? DyfanJones/noctua#235 for details. This causes it to fail to install on CI (see these logs for an example). To fix this, we add a GitHub remote fornoctuato the PTAXSIM packageDESCRIPTIONfile so that renv will install noctua from GitHub.noctuamaintainers fix this issue. To make sure we do that, I subscribed to the issue thread so that I'll receive a notification if it gets closed.pkgdownworkflow that builds our docs is failing because Carto now requires an API key in order to render basemaps. See this workflow log for a sample failure. To fix this, we add aCARTO_API_KEYsecret to the repo, and then mount that secret into the environment when we run pkgdown builds.