Repository navigation
pre-commit: Upgrade third-party actions, switch to uv + R 4.6, and remove PPM override - #50
Merged
Conversation
This was referenced Oct 28, 2026
jeancochrane
marked this pull request as ready for review
October 28, 2026 21:39
Member
Author
|
@wrridgeway I put up a test PR for all projects that use this action, and they all pass the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few small tweaks to the
pre-commitaction:r-lib/actions/setup-rdefaultsuse-public-rspmtotrue, which sets theRENV_CONFIG_REPOS_OVERRIDEenv var to PPM'slatestrepository (source code). This overrides the dated PPM snapshot recorded in the renv lockfile for our R hooks (link). When a pinned package is no longer the latest version, renv installs it from PPM's archive, which can serve a different build than the snapshot. This is currently happening for V8 8.2.0: the archived binary is dynamically linked againstlibnode, which isn't installed on our runners, so V8 fails to load (sample logs); the snapshot's binary, on the other hand, is statically linked. (This is the same issue we were seeing in v8.2.0 binary for R 4.5 on Linux appears to be dynamically linked againstlibnodejeroen/V8#204.) We now setuse-public-rspm: falseexplicitly, since omitting the input still enables it.pre-commitaction are out of date. This PR takes the opportunity to upgrade them.Testing
I wanted to test this PR thoroughly, since it upgrades many components of the
pre-commitaction and we use that action in most of our projects. I did a quick search to identify every project that uses the action and I put up a PR for each project to test the branch:api-res-avmmodel-res-avmmodel-condo-avmservice-alertsassesspyhomevalaws-infrastructureptaxsimpre-commitworkflow is passingassessrdata-architecturemodel-sales-vallightsnipccaoservice-spark-iasworldprocess-appeal-worksheetsenterprise-intelligenceextract-permitsmodel-land-avmrecurring-data-requestsccao-data.github.io