Skip to content

pre-commit: Upgrade third-party actions, switch to uv + R 4.6, and remove PPM override - #50

Merged
jeancochrane merged 2 commits into
mainfrom
jeancochrane/use-upstream-R-package-sources
Oct 28, 2026
Merged

jeancochrane merged 2 commits into
mainfrom
jeancochrane/use-upstream-R-package-sources

Conversation

@jeancochrane

@jeancochrane jeancochrane commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

This PR makes a few small tweaks to the pre-commit action:

  1. Remove Posit Package Manager (PPM) repository override: This is the most important change, and the primary motivation for this PR. r-lib/actions/setup-r defaults use-public-rspm to true, which sets the RENV_CONFIG_REPOS_OVERRIDE env var to PPM's latest repository (source code). This overrides the dated PPM snapshot recorded in the renv lockfile for our R hooks (link). When a pinned package is no longer the latest version, renv installs it from PPM's archive, which can serve a different build than the snapshot. This is currently happening for V8 8.2.0: the archived binary is dynamically linked against libnode, which isn't installed on our runners, so V8 fails to load (sample logs); the snapshot's binary, on the other hand, is statically linked. (This is the same issue we were seeing in v8.2.0 binary for R 4.5 on Linux appears to be dynamically linked against libnode jeroen/V8#204.) We now set use-public-rspm: false explicitly, since omitting the input still enables it.
  2. Upgrade third-party actions: Many of the third-party actions that power the pre-commit action are out of date. This PR takes the opportunity to upgrade them.
  3. Switch to uv and R 4.6: These are the current tools that we use for development, so the pre-commit action should use them too.

Testing

I wanted to test this PR thoroughly, since it upgrades many components of the pre-commit action and we use that action in most of our projects. I did a quick search to identify every project that uses the action and I put up a PR for each project to test the branch:

@wrridgeway wrridgeway left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jean!

@jeancochrane

Copy link
Copy Markdown
Member Author

@wrridgeway I put up a test PR for all projects that use this action, and they all pass the pre-commit workflow. Merging!

@jeancochrane
jeancochrane merged commit bc6775d into main Oct 28, 2026
3 checks passed
@jeancochrane
jeancochrane deleted the jeancochrane/use-upstream-R-package-sources branch October 28, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants