Skip to content

fix: skip optional Website bootstrap on databases without Website - #415

Open
shiny-code-app[bot] wants to merge 1 commit into
mainfrom
work/lp5828-optional-website-bootstrap
Open

shiny-code-app[bot] wants to merge 1 commit into
mainfrom
work/lp5828-optional-website-bootstrap

Conversation

@shiny-code-app

@shiny-code-app shiny-code-app Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Why

CM previews inherit Website settings from the testing lane, but some preview databases do not have the Website module. The bootstrap then raised Website bootstrap supplied, but the website module is not installed., which failed the whole data workflow. Hand overrides with null intent made those previews serve, so skipping the bootstrap is enough.

What changed

apply_website_bootstrap keeps raising when LAUNCHPLANE_WEBSITE_BOOTSTRAP_REQUIRED is enabled. Without the flag, a payload for a database that lacks Website logs the skip and returns. Launchplane already sends the flag for stable lanes and exact preview intent, and stops sending it for template-inherited preview intent in cbusillo/launchplane#5829.

Safe to land first: until Launchplane changes, every Launchplane-managed runtime that renders this payload still sends the flag and stays strict. Local runtimes without the flag now skip instead of failing.

Refs cbusillo/launchplane#5828.

Verification

Removed: the unconditional failure when Website is absent and the bootstrap is optional.
Net lines: +13.

Launchplane marks required Website intent with LAUNCHPLANE_WEBSITE_BOOTSTRAP_REQUIRED. Without it, a payload for a database that lacks the website module logs the skip and continues instead of failing the data workflow.
@shiny-code-app

shiny-code-app Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Review result: weighed
Head: aaacacb

Review by another model, weighed for head aaacacb.

Reviewer: OpenAI through the model-review helper (model not reported by the CLI). Asked whether a run that should fail can now pass silently in startup, data workflows or local runtimes, and whether the skip breaks later settings or readback steps. Answer: none. Nothing to act on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants