Repository navigation
fix: skip optional Website bootstrap on databases without Website - #415
Open
shiny-code-app[bot] wants to merge 1 commit into
Open
shiny-code-app[bot] wants to merge 1 commit into
shiny-code-app[bot] wants to merge 1 commit into
Conversation
Launchplane marks required Website intent with LAUNCHPLANE_WEBSITE_BOOTSTRAP_REQUIRED. Without it, a payload for a database that lacks the website module logs the skip and continues instead of failing the data workflow.
Contributor
Author
|
Review result: weighed Review by another model, weighed for head aaacacb. Reviewer: OpenAI through the model-review helper (model not reported by the CLI). Asked whether a run that should fail can now pass silently in startup, data workflows or local runtimes, and whether the skip breaks later settings or readback steps. Answer: none. Nothing to act on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CM previews inherit Website settings from the testing lane, but some preview databases do not have the Website module. The bootstrap then raised
Website bootstrap supplied, but the website module is not installed., which failed the whole data workflow. Hand overrides with null intent made those previews serve, so skipping the bootstrap is enough.What changed
apply_website_bootstrapkeeps raising whenLAUNCHPLANE_WEBSITE_BOOTSTRAP_REQUIREDis enabled. Without the flag, a payload for a database that lacks Website logs the skip and returns. Launchplane already sends the flag for stable lanes and exact preview intent, and stops sending it for template-inherited preview intent in cbusillo/launchplane#5829.Safe to land first: until Launchplane changes, every Launchplane-managed runtime that renders this payload still sends the flag and stays strict. Local runtimes without the flag now skip instead of failing.
Refs cbusillo/launchplane#5828.
Verification
tests/test_odoo_website_bootstrap.py(31) andtests/test_odoo_startup.py(48) pass. The optional-case test raises without the fix.ruff format --check .andruff check .pass.native_python_support_plugin_unavailable, native PyCharm, 2 files, no findings reported; tracked on Headless inspection workers: confirm project interpreter and Pydantic plugin so type findings stop being noise codex-skills#3363. Not a clean result.Removed: the unconditional failure when Website is absent and the bootstrap is optional.
Net lines: +13.