Repository navigation
Count a testing session as use only when touched in the last day - #5840
Merged
Merged
Conversation
Odoo touches a session file while it is in use. The use check now treats an authenticated session as a person only when its file changed in the same 24-hour window it already uses for sign-ins, instead of anywhere inside Odoo's session lifetime. A session idle for days is stale state. This removes the in-container lifetime reader and its reason code.
Contributor
Author
|
Review result: weighed Independent review: OpenAI via Codex, read-only. The CLI did not report the model. Result: no actionable findings.
|
Contributor
Author
|
Ready for the merge train Head: 765da75 |
Contributor
Author
|
Launchplane completed the merge-train step for this pull request.
Launchplane finished the merge-train step for this pull request. Launchplane manages this comment and will update it as the train moves. |
shiny-code-app Bot
added a commit
that referenced
this pull request
Nov 9, 2026
…ba5aa7afb67736f: merge PR #5840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CM testing restore for #5206 is still refused as
testing_in_useafter #5833 and #5837. A fresh preflight at 3:46 PM ET (tracelaunchplane_req_d293e2eac9044a909c82948ec86b357e, plan61cbcb73…) counts one user,odoo-user:8. Its session was last active 2026-11-08 00:05 UTC, about 45 hours earlier, with no sign-in since. #5833 counts a session as use for as long as Odoo keeps it alive, about seven days. The recorded direction for this lane is narrower: session rows without recent sign-ins are stale state, not a person.What changed: an authenticated session counts as use only when Odoo touched its file in the same window the check already uses for sign-ins. That window is the last 24 hours, and never before the generation boundary. The
deletion_timecheck, a recent sign-in counting as use on its own, the generation boundary, the second scan after SQL, and every unknown-means-protected rule are unchanged.Removed: the in-container reader for Odoo's session lifetime (
SESSION_LIFETIMEsource parsing andsessions.max_inactivity_seconds), itssession_lifetime_unavailablereason code, and four tests for it.Net lines: -109 (+21/-130).
Refs #5206
Validation
test_odoo_testing_usage,test_disposable_lane_collection,test_testing_rebuild_httpandtest_postgres_integrationpass. Postgres integration was skipped locally and runs in CI. Ruff, format and mypy are clean.Client test notes
Nothing for the Client to test. The restore itself stays with its operator.