Repository navigation
Use one expiry-based account strategy and measured pace targets - #1115
Conversation
|
Review result: weighed Anthropic claude-opus-5-5 reviewed the implementation read-only. The CLI confirmed the model. Acted on findings 1–10: unknown credits no longer suppress the known-capacity outage warning; targets account for known short-window room and report unproved feasibility; the requested reset depletion lead is a day and advice waits for zero; credit burn excludes time before quota reached zero; credits remain usable while another account is gated; companion evidence carries only normalized planning values; event-driven credit deadlines persist; batches account for pending short-window room and unmeasured batches are smaller; TV reads the shared strategy; unselected depletion predictions, duplicate exclusions, empty credit dictionaries and duplicated forecast calculation are removed. Restored useful assumption, multiple-mark, cushion and shared-observation coverage. Removed the speculative credit-at-risk amount from one balance. Declined: a hard ceiling at today's measured burn would prevent adding real work, contrary to #1114. Known gate capacity bounds targets, unproved feasibility is explicit, and an unmeasured batch is limited to one pending launch per account. A known gated account still has quota, so it continues to hold the protected cushion under the Director's stated last-account rule; it no longer blocks usable credits. Unknown or saved quota is not treated as empty. Finding 11's suggestion to count Claude grants without explicit general-week coverage contradicts the specification; those grants remain unknown and cannot steer launches. Confirmed the catalog consumer reads answers.useNext and launchOrder; it does not decode removed tiers, weights or starter fields. Its existing smaller-batch route supports bounded unmeasured launch orders. No schema-version change is needed for that consumer. The reference-image update and a focused rereview remain before Ready. |
|
Review result: weighed Review of record: Anthropic claude-opus-5-5, confirmed by the CLI, effort unknown. The source reviews are complete and weighed through their latest findings. Fresh read-only design assessments interrupted both patch cycles; local corrections afterward pass 178 focused checks and the native build. IDE remains UNKNOWN (isolated_backend_unavailable); Q1333 permits proceeding. Acted on: qualified reset inventory; known-capacity outage warnings; measured credit-spend intervals and normalized companion transport; bounded pending batches and retry time; parallel per-account allocation; current credit units and mixed targets; retention of gated weekly quota for replanning; applicable valuable final-day reset advice; the shared application lead and forecast-resolution boundary; notification timing; qualified credit/deadline presentation; compact shared Mac/TV explanations and useful regression coverage. Banked resets are still applied only by the Director. Declined with checked evidence:
Source consumer compatibility was checked against the catalog's account_choice.py. The second PR removes its duplicated pacing instructions only after this PR lands. Final visual review: Anthropic claude-opus-5-5 (CLI-confirmed, effort unknown), covering all six old/new image pairs at fc8ed59. It confirmed legibility, no clipping, correct fixture target arithmetic and consistent earlier-expiry picks on phone, widget and Vision Pro. Visual findings weighed:
All review findings are accounted for. The installed app was preserved; this source review and CI fixture evidence do not claim installed-runtime acceptance. Current-head CI is still required before Ready. |
|
Ready for the merge train Head: fc8ed59 |
|
Launchplane completed the merge-train step for this pull request.
Launchplane finished the merge-train step for this pull request. Launchplane manages this comment and will update it as the train moves. |
…-f6e5eab324502f96: merge PR #1115
Use next now spends capacity in deadline order and publishes the pace launching agents should follow. This fixes both skipping the marked account's earlier reset and spending credits while its last plan quota remains. Expiring banked resets and credits bring forward quota-depletion targets; the marked account keeps its measured cushion while other quota remains.
Claude reset inventory counts only positive general-week refills. Offers and model-only or unknown grants are shown separately. Credit runway stays unknown without measured spend, and reset capacity remains conditional on the Director applying it. The account setting's name is unchanged.
Refs #1114
Fixes #1112
Fixes #1113
Removed: heavy-week mode and saved hysteresis, use-last tiers, starter timing/state, weighted launch splits, and false general-reset capacity from offers/model grants.
Net lines: +66 (1,084 added, 1,018 removed; binary images excluded). Ranking and forecast together lose two lines. Growth supplies the 42-line measured credit-history estimator and regression coverage for the retired rules' replacement.
Validation
swift buildpasses.Reference images
The Mac and TV baselines should keep their account cards readable while adding the selected account’s target and deadline. The iPhone, Vision Pro, iPhone widget and Watch stress cells should show unknown measurements plainly and mark the next account. I inspected every new CI-rendered image; they show those facts without new clipping. The Watch capture retains its existing scroll position.
Client test notes
Client change: Use next shows the provider target and the next account's share when parallel work is needed. On the next released build, compare accounts with different reset dates and confirm that the marked account drains above its cushion. Credit-only work can show a multiplier of recent work; unknown measurements remain visible. Reset advice prefers planned depletion, retains valuable partial-reset advice in the final day, and holds a reset while earlier-expiring credits are spent. Only you apply it. Include a reset inside its last day in that check. A pending-only wait shows its retry time; refresh or use a smaller batch. The reset list separates offers/model grants; the TV card, credit explanation and Use last help use the same strategy. The name is unchanged. The installed Production app was preserved; no installed-runtime acceptance is claimed.
The catalog guidance cleanup follows after this PR lands. Supervisor memory deletion and hand-set targets belong to the Supervisor handoff on #1114.