Repository navigation
File simulator reference failures without the retired plan labels - #1092
Merged
Merged
Conversation
Contributor
Author
|
Ready for the merge train Head: fd83025 |
Contributor
Author
|
Launchplane completed the merge-train step for this pull request.
Launchplane finished the merge-train step for this pull request. Launchplane manages this comment and will update it as the train moves. |
shiny-code-app Bot
added a commit
that referenced
this pull request
Nov 9, 2026
…-a6b6418cd17184c9: merge PR #1092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the simulator reference job fails on main,
scripts/ci-reference-failure-issue.pyfiles an issue so the failure is seen. It still passed theplanandplan:activelabels, which were retired and no longer exist in this repository.gh issue createrefused, so the step crashed and no issue was filed. This happened on main run https://github.com/cbusillo/context-panel/actions/runs/42533202447, where the iPad simulator timed out installing the app.The issue is now created without labels. Planning status comes from the issue's wait record, which the script already writes. The test asserted the retired label names, so it passed while the real call failed; that assertion is removed, and the wait-record check stays.
Verification:
uv run --no-project python -m unittest Tests.ScriptsTests.test_ci_reference_failure_issuepasses (6 tests).Removed: the two retired labels and the test assertion that pinned them. Net lines: -2.