Skip to content

Simplify mapped Ubuntu/Unraid OS labels in dashboard UI#4

Merged
cbulock merged 3 commits into
mainfrom
copilot/update-os-name-formatting
May 15, 2026
Merged

Simplify mapped Ubuntu/Unraid OS labels in dashboard UI#4
cbulock merged 3 commits into
mainfrom
copilot/update-os-name-formatting

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

  • Review new PR comment and confirm actionable requested change
  • Inspect current Unraid 6.12 mapping behavior
  • Run frontend baseline build
  • Update Unraid 6.12 mapping to avoid ambiguous series fallback
  • Rebuild frontend to validate change
  • Capture updated UI screenshot
  • Run CodeQL security check
  • Reply to new PR comment with commit hash and screenshot

@cbulock cbulock marked this pull request as ready for review May 15, 2026 13:48
Copilot AI review requested due to automatic review settings May 15, 2026 13:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies OS label rendering in the dashboard by shortening the mapped Ubuntu/Unraid strings and removing appended kernel version details from mapped output.

Changes:

  • Updated formatKernelMappedOs to return only the mapped label (no appended Linux <kernel>).
  • Simplified Unraid kernel-to-OS mappings for certain exact kernel versions to return x-family labels.
  • Replaced Ubuntu “kernel family” mapping labels with direct Ubuntu <release> LTS labels.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
web/src/kernelMappings.js Updates Ubuntu/Unraid kernel mapping labels to be more concise.
web/src/App.vue Changes mapped OS formatting to stop appending the kernel version to mapped labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web/src/kernelMappings.js
Comment on lines +63 to +67
"5.4": "Ubuntu 20.04 LTS",
"5.15": "Ubuntu 22.04 LTS",
"6.2": "Ubuntu 22.04 LTS",
"6.5": "Ubuntu 22.04 LTS",
"6.8": "Ubuntu 24.04 LTS",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in commit 54a47ed.

Changes made:

  • Parse Ubuntu release directly from osDescription when present (e.g., Ubuntu 24.04.3 LTS -> Ubuntu 24.04 LTS) to avoid incorrect kernel-only inference.
  • Updated ambiguous Ubuntu kernel fallbacks to non-single-release labels (5.15 -> Ubuntu 20.04/22.04 LTS, 6.2/6.5 -> Ubuntu 22.04+).

Screenshot: /tmp/os-label-ui.png

Comment thread web/src/kernelMappings.js
Comment on lines 41 to 45
"6.6.78": "Unraid OS 7.0.1",
"6.12.24": "Unraid OS 7.1.0-7.1.4",
"6.12.54": "Unraid OS 7.2.0-7.2.4",
"6.12.24": "Unraid OS 7.1.x",
"6.12.54": "Unraid OS 7.2.x",
"6.12.85": "Unraid OS 7.2.5",
"6.12.87": "Unraid OS 7.2.6",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in commit dd9d3d9.

I removed the 6.12 series fallback mapping so unlisted 6.12.* kernels no longer resolve to the ambiguous Unraid OS 7.1.x-7.2.x label.

Screenshot: /tmp/os-label-ui-unraid-612.png

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,Impro ndor/bin/node (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@cbulock
Copy link
Copy Markdown
Owner

cbulock commented May 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com

    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,Impro ndor/bin/node (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@copilot can you continue this work but just ignoring whatever you were trying to do font-wise?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,Impro lib/node-gyp-bin/ldd (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning
...

Yes — I continued without any font-related changes and completed the mapping update in dd9d3d9.

Current behavior keeps concise labels and removes the ambiguous Unraid 6.12 series fallback.

Screenshot: /tmp/os-label-ui-unraid-612.png

@cbulock cbulock merged commit 6a5f466 into main May 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants