Potential fix for code scanning alert no. 1: DOM text reinterpreted as HTML#6
Open
cbulock wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 1: DOM text reinterpreted as HTML#6cbulock wants to merge 1 commit into
cbulock wants to merge 1 commit into
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the docs app’s innerHTML string templates against XSS by escaping DOM-derived values before interpolating them into HTML attributes, and by adding runtime allow-list validation for enum-like UI state.
Changes:
- Escapes
activeSectionIdbefore interpolating into thecindor-tabsvalue="..."attribute. - Escapes
activeAlertTonebefore interpolating into thecindor-alerttone="..."attribute. - Adds runtime allow-list validation when assigning
activeAlertToneandcatalogLayerfrom segmented-control values.
Comment on lines
+1449
to
+1452
| catalogLayer = | ||
| nextLayer === "all" || nextLayer === "primitives" || nextLayer === "composites" || nextLayer === "workflows" | ||
| ? nextLayer | ||
| : "all"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/cbulock/cindor/security/code-scanning/1
To fix this without changing functionality, ensure any DOM-derived state that is later interpolated into HTML strings is encoded before insertion into
innerHTMLtemplates. In this file, reuse existing escaping for attribute contexts (escapeAttribute(...)) and add strict runtime validation for enum-like values.Best single approach here:
activeAlertToneat assignment time (inhydrateHomeExamples) so only allowed tones are accepted.renderDocsHome, especially:value="${activeSectionId}"→value="${escapeAttribute(activeSectionId)}"tone="${activeAlertTone}"→tone="${escapeAttribute(activeAlertTone)}"Edits are all in
apps/docs/src/main.tsin the shown regions around:renderDocsHome(...)template interpolations.toneSelectorandlayerFilterchange handlers inhydrateHomeExamples().Suggested fixes powered by Copilot Autofix. Review carefully before merging.