Repository navigation
Keep email review events in the future - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The email review test used fixed event dates. Once the favorited event was in the past, D1 correctly rejected the insert and the test failed. This is the existing failure blocking #14.
Use one captured run time for the sample dates, place publication dates in the completed digest week, and schedule both events in the future. Assert that both events appear in the text and HTML of the general and personalized digests.
Validation with Node.js 24.22.0:
npm run verifypasses, including 158 Workers integration tests and 37 static/tooling tests.npm run public:history-checkpasses.