Repository navigation
Conversation
Only send preliminary HEAD probes for bodyless GET requests. A probe otherwise consumes and closes the shared body or becomes the final response for an in-memory download, skipping the requested method. Fixes cavaliergopher#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preliminary HEAD request shallow-copies the download request, including its body. That can consume the body before the POST/GET download, and an in-memory download can finish using the HEAD response without issuing the requested method at all.
Only probe bodyless GET requests. Send other methods and body-bearing requests directly, preserving the caller's method and body. Fixes #93.
Validation on Linux / Go 1.26.10:
make checkpasses: formatting, vet, pinned staticcheck, tidy, complete shuffled race/coverage suites, and CLI build.govulncheckv1.9.0 reports no vulnerabilities with this toolchain.