fix(buffer): wrap non-virtualtext nvim_buf_set_extmark in pcall#214
Open
fei6409 wants to merge 1 commit into
Open
fix(buffer): wrap non-virtualtext nvim_buf_set_extmark in pcall#214fei6409 wants to merge 1 commit into
fei6409 wants to merge 1 commit into
Conversation
When scrolling or editing rapidly, asynchronous updates or byte-offset calculation misalignments (e.g. in files with control characters like '^[[1;31m' or multi-byte sequences) can attempt to apply highlights to invalid column ranges. This causes Neovim to throw an "Invalid 'end_col': out of range" error in function nvim_buf_set_extmark(). Wrap the non-virtualtext highlight application in a pcall to safely ignore stale or invalid column offsets. This provides the same protection already present in the virtualtext highlighting logic in the same function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scrolling or editing rapidly, asynchronous updates or byte-offset calculation misalignments (e.g. in files with control characters like '^[[1;31m' or multi-byte sequences) can attempt to apply highlights to invalid column ranges. This causes Neovim to throw an "Invalid 'end_col': out of range" error in function nvim_buf_set_extmark().
Wrap the non-virtualtext highlight application in a pcall to safely ignore stale or invalid column offsets. This provides the same protection already present in the virtualtext highlighting logic in the same function.