Fix repeated SECTIONs in one test cycle#3178
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SECTIONwhen the same source location is encountered again after the current test cycle has completedRoot cause
A helper called twice in the same test cycle can reacquire a section that is still marked open after one of its children completed the cycle. The second acquisition skips reopening it, but the public section wrapper still treats it as open and later closes it from an invalid tracker position, causing a hang or crash.
Validation
cmake --build build --config Debug --target SelfTest --parallel 1build/tests/Debug/SelfTest.exe "Tracker rejects a section encountered twice in one cycle" --reporter compactbuild/tests/Debug/SelfTest.exe "Tracker" --reporter compactFixes #2802